Feature/gcc ng #40637

angerman · 2018-05-17T06:52:39Z

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

angerman · 2018-05-17T06:59:56Z

@Ericson2314 as I mentioned earlier...

This is a rather rough cut, and it doesn't allow me to build packages with it yet, due to some missing headers (e.g. mingw-w64) isn't properly injected into the CFLAGS, and as such building packages like zlib will fail with <stdio.h> not found.

The general idea:

configure gcc and build gcc (all-gcc) out of tree.
collect the build results and the source, and call this -prebuilt.
Use -prebuilt to actually install gcc (install-gcc) -- This is a gcc, with no libgcc, and no libc.
Build the libc (in my case that's msvcrt) -- now we have a gcc, with no libgcc, but a libc.
Build any additionally needed libraries (e.g. winpthreads)
Use -prebuilt to build libgcc (all-target-libgcc and install-target-libgcc). We could also build any other gcc component here, based off of the prebuilt tree.

Finally use 1+4+5+6 to actually have a proper cross gcc.

Any suggestions are welcome!

PS: Yes, I tried to make this work in the existing gcc expression. I tried to follow the GNU/Hurd appraoch with the libpthreadCross, but could not make it work without constantly running into include/library issues.

Ekleog

Just a few comments, I don't know enough about both mingw and cross-compilation to say whether this is wanted or a good implementation :)

cc @Ericson2314 for a more general “is this a good idea?” review

Ekleog · 2018-11-29T00:15:28Z

pkgs/development/compilers/gcc/7/default-ng-prebuilt.nix

+    binutils
+  ] ++ extraBuildInputs;
+
+  # bould out of tree. We don't use `pwd` in the `configureScript` so


Suggested change

# bould out of tree. We don't use `pwd` in the `configureScript` so

# build out of tree. We don't use `pwd` in the `configureScript` so

Ekleog · 2018-11-29T00:20:57Z

pkgs/os-specific/windows/pthread-w32/default.nix

@@ -1,7 +1,7 @@
 { fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }:


With the change below,

Suggested change

{ fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }:

{ fetchurl, stdenv, mingw_header }:

Ekleog · 2018-11-29T00:22:41Z

pkgs/top-level/all-packages.nix

@@ -6092,7 +6092,7 @@ with pkgs;
  gerbil-unstable = callPackage ../development/compilers/gerbil/unstable.nix { };

  gccFun = callPackage ../development/compilers/gcc/7;
-  gcc = gcc7;
+  gcc = gcc7-ng-msvcrt;


Isn't this setting all gcc to be msvcrt-based, thus breaking the package for non-windows?

Ekleog · 2018-11-29T00:25:03Z

pkgs/top-level/all-packages.nix

@@ -11433,7 +11482,7 @@ with pkgs;

  rlog = callPackage ../development/libraries/rlog { };

-  rocksdb = callPackage ../development/libraries/rocksdb { jemalloc = jemalloc450; };
+  rocksdb = callPackage ../development/libraries/rocksdb { stdenv = overrideCC stdenv gcc7-ng-msvcrt; jemalloc = jemalloc450; };


Same here, won't setting the compiler to msvcrt break the package on non-windows?

Ekleog · 2018-11-29T00:26:36Z

pkgs/development/compilers/gcc/7/default-ng-prebuilt.nix

+  };
+
+  buildInputs = [
+    gmp mpfr libmpc #libelf


Suggested change

gmp mpfr libmpc #libelf

gmp mpfr libmpc

Or add a comment as to why it is left here

mmahut · 2019-08-11T06:09:53Z

Are there any updates on this pull request, please?

stale · 2020-06-01T16:08:35Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

Mindavi · 2021-10-13T18:09:48Z

Pretty sure this is made obsolete by #132343. Please reopen if not.

angerman added 6 commits May 17, 2018 14:45

cleanup

c323ec2

proper mingw names

8dc8cc7

cleanup mingw

7611932

Adds preliminary gcc-ng infra.

7b1a29a

make bulding libgcc work.

60e2923

use gcc7-ng-msvcrt by default.

8961779

angerman requested review from Ericson2314 and nbp as code owners May 17, 2018 06:52

angerman mentioned this pull request Jul 25, 2018

libgcc: Init at 7.3.0 #44069

Merged

10 tasks

veprbl added the 2.status: merge conflict label Nov 28, 2018

Ekleog reviewed Nov 29, 2018

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

Ericson2314 mentioned this pull request Aug 1, 2021

New GCC packaging -- separating compilers from runtime libraries #132340

Open

Mindavi closed this Oct 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/gcc ng #40637

Feature/gcc ng #40637

angerman commented May 17, 2018

angerman commented May 17, 2018

Ekleog left a comment

Ekleog Nov 29, 2018

Ekleog Nov 29, 2018

Ekleog Nov 29, 2018

Ekleog Nov 29, 2018

Ekleog Nov 29, 2018

mmahut commented Aug 11, 2019

stale bot commented Jun 1, 2020

Mindavi commented Oct 13, 2021

	# bould out of tree. We don't use `pwd` in the `configureScript` so
	# build out of tree. We don't use `pwd` in the `configureScript` so

		@@ -1,7 +1,7 @@
		{ fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }:

	{ fetchurl, stdenv, mingw_header, hostPlatform, buildPlatform }:
	{ fetchurl, stdenv, mingw_header }:

Feature/gcc ng #40637

Feature/gcc ng #40637

Conversation

angerman commented May 17, 2018

Motivation for this change

Things done

angerman commented May 17, 2018

Ekleog left a comment

Choose a reason for hiding this comment

Ekleog Nov 29, 2018

Choose a reason for hiding this comment

Ekleog Nov 29, 2018

Choose a reason for hiding this comment

Ekleog Nov 29, 2018

Choose a reason for hiding this comment

Ekleog Nov 29, 2018

Choose a reason for hiding this comment

Ekleog Nov 29, 2018

Choose a reason for hiding this comment

mmahut commented Aug 11, 2019

stale bot commented Jun 1, 2020

Mindavi commented Oct 13, 2021