New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geant4 overhaul #40618
geant4 overhaul #40618
Conversation
Failure on x86_64-darwin (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
I can only approve these changes. Can't comment on g4py though. I do wonder, though: is there any reason to default dependencies to |
Success on x86_64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
@tmplt You are right. This stuff is just bizarre. I've pushed commit to remove that. |
Failure on x86_64-darwin (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
I think this is good to merge. Can anyone take a look? |
Any chance to have this merged? |
Sounds OK to merge, except that when I merge it with master, |
@GrahamcOfBorg build g4py |
Failure on x86_64-darwin (full log) Attempted: g4py Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: g4py Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: g4py Partial log (click to expand)
|
1e425cc
to
9075d92
Compare
Failure on x86_64-darwin (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
Let's merge? |
Ping |
Nobody maintains this and this does not contribute anything towards making reproducible research. Also this was missing recurseIntoAttrs, so Hydra used to not see it.
9075d92
to
fc4f99a
Compare
Had to rebase after 2c2f1e3 . Can we please merge? |
Success on aarch64-linux (full log) Attempted: g4py, geant4 Partial log (click to expand)
|
So will this not get merged? |
I opened #46019 hoping to increase visibility. That had no effect. I don't understand why this particular PR gets so little traction. |
I'd expect the main reason is that only very small fraction of nixpkgs users will utilize such a package. |
Motivation for this change
Update geant4 expression to conform to usual practices used in nixpkgs.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)cc @tmplt