Merge categories and sections (nuke sections) #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CRIPTIONS}` Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
… where their posts are Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
felixfontein
approved these changes
May 4, 2018
docs/manual.rst
Outdated
| Configuring tags, categories and sections | ||
| ````````````````````````````````````````` | ||
| Configuring tags and categories | ||
| ``````````````````````````````` | ||
|
|
||
| There are multiple configuration variables dedicated to each of the three taxonomies. You can set: |
|
|
||
| for section_config_suffix, cat_config_suffix in ( | ||
| ('DESCRIPTIONS', 'DESCRIPTIONS'), | ||
| ('TITLE', 'TITLES'), |
There was a problem hiding this comment.
Yay to the special cases...
nikola/nikola.py
Outdated
| utils.LOGGER.info("Setting CATEGORY_DESTPATH_AS_DEFAULT = " + str(self.config['CATEGORY_DESTPATH_AS_DEFAULT'])) | ||
|
|
||
| if self.config.get('CATEGORY_PAGES_FOLLOW_DESTPATH') and (not self.config.get('CATEGORY_ALLOW_HIERARCHIES') or self.config.get('CATEGORY_OUTPUT_FLAT_HIERARCHY')): | ||
| utils.LOGGER.warn('CATEGORY_PAGES_FOLLOW_DESTPATH requires CATEGORY_ALLOW_HIERARCHIES = True, CATEGORY_OUTPUT_FLAT_HIERARCHY = False.') |
There was a problem hiding this comment.
Why not make this an error and exit? Or explicitly state that the user-supplied values of CATEGORY_ALLOW_HIERARCHIES and CATEGORY_OUTPUT_FLAT_HIERARCHY are ignored?
|
My blogs still compile as before. Everything's fine. |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
3 tasks
… match category renames Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2833. Sections are gone, categories can now do everything sections used to do.
Still to do: write a blog post to help people transition. Everything else works, including on Windows.
Close #3023, close #2486 (subdirectories are supported, and
blog/foo/barcan be interpreted asfoo/bar)Close #2067 (categories appear in the usual place)
Close #2484, although categories don’t seem to be displayed either? (easy fix)
Close #2538 (sections are gone)
Thedone (section_prevnextneeds a rewrite/adjustments/rename.v8/category_prevnext)Sample site I used for testing: section_replacement.zip