Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: disable failing test w/musl for now #39945

Merged
merged 1 commit into from May 3, 2018
Merged

git: disable failing test w/musl for now #39945

merged 1 commit into from May 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 3, 2018

I'm working to resolve this but it will take some time
(patches sent to upstream musl, maybe to git afterwards)
and for now this blocks quite a lot.

If that doesn't work out we can explore options such as
always using GNU libiconv with musl.

For the curious, here's what I sent upstream:
(waiting for response/discussion before applying to our musl)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
git: disable failing test w/musl for now
481ca44 
I'm working to resolve this but it will take some time
(patches sent to upstream musl, maybe to git afterwards)
and for now this blocks quite a lot.

If that doesn't work out we can explore options such as
always using GNU libiconv with musl.
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: git

Partial log (click to expand)

warning: unable to download 'https://cache.nixos.org/jfasr8z4n7wh4cnq8zga9r8cfkyqrn6c.narinfo': HTTP error 504 (curl error: No error); retrying in 5166 ms
warning: unable to download 'https://cache.nixos.org/nlcs4r6whq0cv7lx6n783qbx466fswc5.narinfo': HTTP error 504 (curl error: No error); retrying in 4947 ms
warning: unable to download 'https://cache.nixos.org/85hyv7m2h05rs47xcmv1l2f749vhg51h.narinfo': HTTP error 504 (curl error: No error); retrying in 8160 ms
warning: unable to download 'https://cache.nixos.org/jfasr8z4n7wh4cnq8zga9r8cfkyqrn6c.narinfo': HTTP error 504 (curl error: No error); retrying in 8335 ms
warning: unable to download 'https://cache.nixos.org/nlcs4r6whq0cv7lx6n783qbx466fswc5.narinfo': HTTP error 504 (curl error: No error); retrying in 11234 ms
warning: unable to download 'https://cache.nixos.org/85hyv7m2h05rs47xcmv1l2f749vhg51h.narinfo': HTTP error 504 (curl error: No error); retrying in 17221 ms
warning: unable to download 'https://cache.nixos.org/jfasr8z4n7wh4cnq8zga9r8cfkyqrn6c.narinfo': HTTP error 504 (curl error: No error); retrying in 17844 ms
warning: unable to download 'https://cache.nixos.org/nlcs4r6whq0cv7lx6n783qbx466fswc5.narinfo': HTTP error 504 (curl error: No error); retrying in 22263 ms
error (ignored): unable to download 'https://cache.nixos.org/jfasr8z4n7wh4cnq8zga9r8cfkyqrn6c.narinfo': HTTP error 504 (curl error: No error)
error: unexpected end-of-file

@dtzWill dtzWill merged commit 1abe8fa into NixOS:staging May 3, 2018
@dtzWill dtzWill deleted the fix/temp-workaround-git-test-musl branch May 3, 2018 20:48
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=801, Tests=18583, 411 wallclock secs ( 4.44 usr  0.90 sys + 257.57 cusr 253.39 csys = 516.30 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.17.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.17.0/t'
make[1]: Leaving directory '/build/git-2.17.0/t'
/nix/store/nfgv8hwa4dsyqw4skqfqjprm7zwzbyya-git-2.17.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: git

Partial log (click to expand)

All tests successful.
Files=801, Tests=18583, 199 wallclock secs (82.98 usr 17.30 sys + 2693.10 cusr 7292.27 csys = 10085.65 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.17.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.17.0/t'
make[1]: Leaving directory '/build/git-2.17.0/t'
/nix/store/3bpai68lhxbg37sy52vw87vv6mi8yff3-git-2.17.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg