Treat installed DLC as compatible dependency #2424
Merged
+112
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Modules that depend on
MakingHistory-DLC
are treated as incompatible in mod listings, even if you have the DLC.You are still able to install such modules via CmdLine, even though they are displayed as incompatible.
Relatedly, the MakingHistory-DLC entry in the relationships tab always shows up as red and "(not indexed").
Cause
DLC checks were only added to functions that check whether an identifier is installed. To determine whether a module is compatible, we look up all of its dependencies via
LatestAvailableWithProvides
regardless of whether they're already installed, which returns a module, and there are no modules for Dlc objects, so this function doesn't find anything forMakingHistory-DLC
.The relationships tab in GUI also checks dependencies itself, and also wasn't updated.
Changes
Now the helper function that checks dependencies treats installed DLC identifiers as compatible.
The relationships tab also now checks for installed DLC and shows it as compatible if it's installed.
Fixes https://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan-the-comprehensive-kerbal-archive-network-v1250-wallops/&do=findComment&comment=3362539
Tests are added: