Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clementine: each output should hav a wrapped GST_PLUGIN_SYSTEM_PATH_1_0 #39439

Merged
merged 1 commit into from Apr 25, 2018
Merged

clementine: each output should hav a wrapped GST_PLUGIN_SYSTEM_PATH_1_0 #39439

merged 1 commit into from Apr 25, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 24, 2018 •
edited

Motivation for this change

see ef5e212#r28723596

/cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2018

cc #39409: @mrkkrp @matthewbauer

@Ma27
Copy link
Member Author

Ma27 commented Apr 24, 2018

it's odd, I get the same issue as on master:

23:37:09.075 WARN  unknown                          libpng warning: iCCP: known incorrect sRGB profile 
23:37:09.118 WARN  unknown                          QPainter::begin: Paint device returned engine == 0, type: 2 
23:37:09.485 ERROR unknown                          JSonScanner::yylex - error while reading from io device  
23:37:09.485 ERROR unknown                          json_parser - syntax error found,  forcing abort, Line 1 Column 1

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2018 •
edited

It is supposed to fix the crash when you try to play some music.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: clementine

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1
shrinking /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1/bin/clementine-tagreader
shrinking /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1/bin/.clementine-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1/bin
patching script interpreter paths in /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1
checking for references to /build in /nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1...
/nix/store/qlb354dc8jzq44ih45d3h9d1n4ih7fal-clementine-free-1.3.1

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: clementine

Partial log (click to expand)

make[2]: Leaving directory '/build/qt-everywhere-opensource-src-4.8.7/src/plugins/accessible'
g++ -c -pipe -O2 -fvisibility=hidden -fvisibility-inlines-hidden -D_REENTRANT -Wall -W -fPIC -DQT_NO_DEBUG -DQT_PLUGIN -DQT_DBUS_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_SHARED -I../../../../mkspecs/linux-g++ -I. -I../../../../include/QtCore -I../../../../include/QtNetwork -I../../../../include/QtDBus -I../../../../include -I.moc/release-shared -o .obj/release-shared/moc_qnetworkmanagerengine.o .moc/release-shared/moc_qnetworkmanagerengine.cpp
building of '/nix/store/zhsf00dbj1qmq7c222ag4jh0256ppcrr-qt-4.8.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/s95i32rjvrb51mwj146fbyjmcykbsp0d-liblastfm-1.0.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/647vir78kwdlpfqllwsn7lrv8kpr1cdr-projectm-2.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/293m884v3y9k3b85grgv10mfpyh7yjv5-qca-2.1.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sxwjg47144p2f5ybjxhpw1ykrr6bb3sz-qjson-0.9.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/l6nfg6q46ndrbnbyp7937k7h0bjg251b-libechonest-2.3.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/x6xw3an0r73qllfcj6b9bmrv6rrarfzl-clementine-free-1.3.1.drv': 7 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/x6xw3an0r73qllfcj6b9bmrv6rrarfzl-clementine-free-1.3.1.drv' failed

@matthewbauer matthewbauer merged commit 42c87d4 into NixOS:master Apr 25, 2018
@Ma27 Ma27 deleted the fix-free-clementine-plugin-path branch April 25, 2018 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @jtojnar @GrahamcOfBorg @matthewbauer