Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googleearth: remove #39426

Merged
merged 1 commit into from May 4, 2018
Merged

googleearth: remove #39426

merged 1 commit into from May 4, 2018

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Apr 24, 2018

it's broken, and even after adjusting the derivation to the currently
available downloads it does not run well for me and it is rather
annoying to adjust the derivation to the moving
google-earth-stable_current source download link

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

it's broken, and even after adjusting the derivation to the currently
available downloads it does not run well for me and it is rather
annoying to adjust the derivation to the moving
google-earth-stable_current source download link
@matthewbauer
Copy link
Member

This is unfortunate but probably the right way to go. It might be useful in an overlay if someone is willing to maintain it. See also #30539.

/cc @peterhoeg @viric

@peterhoeg
Copy link
Member

I'm with you guys on this. @viric?

@matthewbauer
Copy link
Member

matthewbauer commented Apr 30, 2018

One thing I forgot to mention: In general we need to get better at documenting breaking changes like this. I think this should go in rl-1809.xml. If possible it would be great, for someone to add it in as a bullet point (we will probably be looking closer at these in August and September but it's nice to get a start on them now.)

@woffs
Copy link
Contributor Author

woffs commented Apr 30, 2018

NB: it could also be fixed, I got https://gist.github.com/def74bf9ff71abae05f7dcab12cd91b5 almost running, but maintenance is the main problem I think, with the google download link which changes content and version and must be (automatically?) adapted in nix.

@matthewbauer matthewbauer merged commit ac18012 into NixOS:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants