Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin-{unlimited,xt}: fix darwin #39310

Merged
merged 1 commit into from Apr 23, 2018
Merged

bitcoin-{unlimited,xt}: fix darwin #39310

merged 1 commit into from Apr 23, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 21, 2018 •
edited

Motivation for this change

blind fix based on hydra.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Apr 21, 2018
@Mic92
Copy link
Member Author

Mic92 commented Apr 21, 2018

@GrahamcOfBorg build altcoins.bitcoin-unlimited altcoins.bitcoin-xt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

  /nix/store/8gcnkhm8xm1qa5w2dkzpzpdq3aifk4kx-miniupnpc-1.9.20160209
  /nix/store/kw5w3hrzlwk9j422plgscmwv5c5970ra-bitcoin-xt-0.11H
  /nix/store/qn8hpaamvr11w9p5hcx7cnhac3w4fz6m-db-4.8.30
copying path '/nix/store/qn8hpaamvr11w9p5hcx7cnhac3w4fz6m-db-4.8.30' from 'https://cache.nixos.org'...
copying path '/nix/store/8bb4rdjslwcpg1dz1falrr5gilr9nldb-boost-1.65.1' from 'https://cache.nixos.org'...
copying path '/nix/store/8gcnkhm8xm1qa5w2dkzpzpdq3aifk4kx-miniupnpc-1.9.20160209' from 'https://cache.nixos.org'...
copying path '/nix/store/7jk8dcvlwzzwhb31p0yw13va629whm8q-bitcoin-unlimited-1.0.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/kw5w3hrzlwk9j422plgscmwv5c5970ra-bitcoin-xt-0.11H' from 'https://cache.nixos.org'...
/nix/store/7jk8dcvlwzzwhb31p0yw13va629whm8q-bitcoin-unlimited-1.0.3.0
/nix/store/kw5w3hrzlwk9j422plgscmwv5c5970ra-bitcoin-xt-0.11H

Mic92
Mic92 commented Apr 21, 2018
View reviewed changes
pkgs/applications/altcoins/default.nix Outdated
@@ -10,13 +10,19 @@ rec {
bitcoin-abc = libsForQt5.callPackage ./bitcoin-abc.nix { boost = boost165; withGui = true; };
bitcoind-abc = callPackage ./bitcoin-abc.nix { boost = boost165; withGui = false; };

bitcoin-unlimited = callPackage ./bitcoin-unlimited.nix { withGui = true; };
bitcoin-unlimited = callPackage ./bitcoin-unlimited.nix {
inherit (darwin.apple_sdk.frameworks) Foundation ApplicationServices AppKit;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In nix repl I see darwin.apple_sdk.frameworks.Foundation why does inheriting not work here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is working but note you also have to pass it to bitcoind-unlimited below. It should probably use overrideAttrs but that's not how any of them are now sadly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's probably not needed for "withGui = false".

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

#include <QLabel>
         ^~~~~~~~
1 error generated.
make[2]: *** [Makefile:6697: qt/bitcoin_qt-bitcoin.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-bitcoin-xt-0.11H.drv-0/source/src'
make[1]: *** [Makefile:7935: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-bitcoin-xt-0.11H.drv-0/source/src'
make: *** [Makefile:649: all-recursive] Error 1
builder for '/nix/store/i8nrzwbd8jb25vghpmwafqzvz1kwh32m-bitcoin-xt-0.11H.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/cdxdc0akd8318zv4magklda0fq2l5j3r-bitcoin-unlimited-1.0.3.0.drv', '/nix/store/i8nrzwbd8jb25vghpmwafqzvz1kwh32m-bitcoin-xt-0.11H.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

In file included from ../JavaScriptCore/wtf/PassRefPtr.h:25:0,
                 from page/WebKitAnimationList.h:29,
                 from page/WebKitAnimationList.cpp:27:
../JavaScriptCore/wtf/NullPtr.h:48:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++11-compat]
 extern std::nullptr_t nullptr;
 ^~~~~~
building of '/nix/store/7zva36frfdcfa9fpydzw2wkbx26yb163-qt-4.8.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/vdvipj941dzn2sl3npj0wvhxhjb660zg-bitcoin-unlimited-1.0.3.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mjkhqgn5avp60ryc3rwsr1lpn58is5v9-bitcoin-xt-0.11H.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/mjkhqgn5avp60ryc3rwsr1lpn58is5v9-bitcoin-xt-0.11H.drv', '/nix/store/vdvipj941dzn2sl3npj0wvhxhjb660zg-bitcoin-unlimited-1.0.3.0.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Apr 22, 2018

@GrahamcOfBorg build altcoins.bitcoin-unlimited altcoins.bitcoin-xt

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

/nix/store/7jk8dcvlwzzwhb31p0yw13va629whm8q-bitcoin-unlimited-1.0.3.0
/nix/store/kw5w3hrzlwk9j422plgscmwv5c5970ra-bitcoin-xt-0.11H

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

#include <QLabel>
         ^~~~~~~~
1 error generated.
make[2]: *** [Makefile:6697: qt/bitcoin_qt-bitcoin.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-bitcoin-xt-0.11H.drv-0/source/src'
make[1]: *** [Makefile:7935: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-bitcoin-xt-0.11H.drv-0/source/src'
make: *** [Makefile:649: all-recursive] Error 1
builder for '/nix/store/i8nrzwbd8jb25vghpmwafqzvz1kwh32m-bitcoin-xt-0.11H.drv' failed with exit code 2
error: build of '/nix/store/cdxdc0akd8318zv4magklda0fq2l5j3r-bitcoin-unlimited-1.0.3.0.drv', '/nix/store/i8nrzwbd8jb25vghpmwafqzvz1kwh32m-bitcoin-xt-0.11H.drv' failed

@Mic92
Copy link
Member Author

Mic92 commented Apr 22, 2018

now it fails for different reason.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: altcoins.bitcoin-unlimited, altcoins.bitcoin-xt

Partial log (click to expand)

                                                  ^~~~~
./leveldbwrapper.h:155:63: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
     bool WriteBatch(CLevelDBBatch& batch, bool fSync = false) throw(leveldb_error);
                                                               ^~~~~
./leveldbwrapper.h:163:17: warning: dynamic exception specifications are deprecated in C++11 [-Wdeprecated]
     bool Sync() throw(leveldb_error)
                 ^~~~~
  CXX      test/test_bitcoin-compactblockprocessor_tests.o
building of '/nix/store/mjkhqgn5avp60ryc3rwsr1lpn58is5v9-bitcoin-xt-0.11H.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/mjkhqgn5avp60ryc3rwsr1lpn58is5v9-bitcoin-xt-0.11H.drv' failed

@Mic92 Mic92 merged commit d52e5da into NixOS:master Apr 23, 2018
@Mic92 Mic92 deleted the bitcoin-fixes branch April 23, 2018 07:37
@Mic92
Copy link
Member Author

Mic92 commented Apr 23, 2018

Still not fixed, but maybe somebody can continue from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @matthewbauer