Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we don't need to build a composite key #16565

Merged
merged 3 commits into from Apr 23, 2018
Merged

we don't need to build a composite key #16565

merged 3 commits into from Apr 23, 2018

Conversation

krisselden
Copy link
Contributor

the layout and component are stable and can be used as the key

@rwjblue
Copy link
Member

rwjblue commented Apr 22, 2018

Restarted CI

@rwjblue
Copy link
Member

rwjblue commented Apr 22, 2018

CI failures seem related to the changes here, other PR's and builds are consistently passing.

@krisselden krisselden requested a review from rwjblue April 23, 2018 00:07
@rwjblue rwjblue merged commit c2de30a into master Apr 23, 2018
@rwjblue rwjblue deleted the simplify-cache branch April 23, 2018 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krisselden @rwjblue