Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pp: fix the width and indentation of second and later line contents #5978

Merged
merged 1 commit into from Apr 21, 2018
Merged

pp: fix the width and indentation of second and later line contents #5978

merged 1 commit into from Apr 21, 2018

Conversation

makenowjust
Copy link
Contributor

For example,

class X
  def pretty_print(pp : PrettyPrint)
    100.times do
      pp.group do
        pp.text "x"
        pp.breakable
      end
    end
  end
end

pp X.new

Above code prints this:

X.new # => x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x
           x x x x x x x x x x x x x x x x x x x x x x x x x x x x x
           x x x x x x x x x x x x x x x x x x x x x x x x x x x x x
           x x x x x x x

This second and third lines are shorter than first line, it seems odd.

Expected result:

X.new # => x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x
           x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x
           x x x x x x x x x x x x x x x x x x x x x x x x x x x x x x

This PR fixes pp and PrettyPrint to output correctly.

@RX14 RX14 added this to the Next milestone Apr 21, 2018
@RX14 RX14 merged commit 32f46c1 into crystal-lang:master Apr 21, 2018
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
@makenowjust @chris-huxtable
pp: fix the width and indentation of second and later line contents (c…
1c33462 
…rystal-lang#5978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@RX14 RX14 RX14 approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@makenowjust @asterite @RX14 @wooster0