[WIP] pijul: 0.8.0 -> 0.10.0 #39287
[WIP] pijul: 0.8.0 -> 0.10.0 #39287
Conversation
Removes the hacky carge update
| version = version; | ||
| sha256 = "0q2hmavsnmmpb1lmq774wdz9yy3m7j2j47l0s2n1715yg7pv42jg"; | ||
| extraPostFetch = '' | ||
| cp ${./Cargo.lock} $out/Cargo.lock |
There was a problem hiding this comment.
I would like to avoid adding large files to nixpkgs. Can you make this a gist or git source?
There was a problem hiding this comment.
Ideally also with a comment on how to update it.
There was a problem hiding this comment.
This is the hack I also don't want in nixpkgs, it's not needed once the download page has the new version
|
Wait, this should ideally be done via Carnix. @infinisil, if you don't want to do this, I can do it as well, just tell me. |
|
@P-E-Meunier I had trouble with the Cargo.lock file from the Nest, it seemed to be a patch with I can do the carnix thing if there is an 'official' Cargo.lock file. Why not just use |
|
There is an official Cargo.lock file, you said it had a conflict. Pushing a patch that fixes that conflict would be more useful than creating a potentially different Cargo.lock. Carnix is smarter than |
|
I see, well I've never actually used Pijul or Rust more than 10 minutes, so I'm pretty inexperienced with this (I even did more Rust packaging for nixpkgs than that :P). Feel free to open your own PR with how you intend to have it in nixpkgs, I'll then close this one. |
|
Ok, sorry, I didn't know. How about you try Carnix again with the corrected Cargo.lock from the Nest, and ping me at will if that doesn't work? In my experience, Carnix is a much better way of using Rust on NixOS than previous solutions (which is exactly why I wrote it), and we need to use it in order to improve it. |
|
Here's an alternative attempt to implement this: #39313 (based on my previous work on 0.8.3 migration) |
|
Here is another alternative using Carnix: #39317. |
|
Closing in favor of #39317 |
Motivation for this change
Pijul 0.10.0 is now available on crates.io, which seems to be the only way to fetch it for now. This is WIP because it
includes a hack to build the binary from the crate (which doesn't include a Cargo.lock, so the hash might change with future builds)fixed with third commit, still includes littlepostFetchhack to inject Cargo.lock file though.I will update this PR when Pijul 0.10.0 is available from their download page, such that the hack can be removed and this PR be merged.
I provide this PR now for people that wanna try out Pijul with nest.pijul.org (which now requires 0.10.0 to work I believe).
Related is #35225
Ping @P-E-Meunier @grahamc @Ralith @lheckemann @Ekleog
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)