Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

googleearth: init at 7.1.8.3036 #40278

Merged
merged 1 commit into from May 11, 2018
Merged

googleearth: init at 7.1.8.3036 #40278

merged 1 commit into from May 11, 2018

Conversation

markus1189
Copy link
Contributor

@markus1189 markus1189 commented May 10, 2018

Wanted to play with google earth and found #39426. I took the URL from the AUR PKGBUILD, so it seems like the moving link problem is gone.

I tested it locally and it worked without problems, maybe somebody can test whether it works for them too.

/cc @matthewbauer @woffs as you were involved in the issue to remove the package

description = "A world sphere viewer";
homepage = http://earth.google.com;
license = stdenv.lib.licenses.unfree;
maintainers = [ stdenv.lib.maintainers.viric ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you would maintain it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, added myself

@markus1189 markus1189 force-pushed the googleearth branch 2 times, most recently from 3634d41 to 37618cb Compare May 10, 2018 08:10
@xeji
Copy link
Contributor

xeji commented May 10, 2018

If we re-add this (and I'm not saying we should), the release notes entry in 8723594 needs to be reverted.

@markus1189
Copy link
Contributor Author

@xeji Okay I amended the pr. Do you think it would be better to not add this again? And why? I don't know much about the history apart from the fact that the moving link seemed to be annoying (which is fixed by the new link)

@xeji
Copy link
Contributor

xeji commented May 10, 2018

Thanks. I don't know much about the history either. Let's see what people more familiar with the package say.

@matthewbauer
Copy link
Member

Are you not getting this issue from @TealG?

#37655 (comment)

I was under the impression that something was broken (maybe a missing library).

@markus1189
Copy link
Contributor Author

markus1189 commented May 11, 2018

I don't experience the problems mentioned in that issue. It starts fine and I spent quite some time in it without problems

@FRidh
Copy link
Member

FRidh commented May 11, 2018

Can you remove @viric as maintainer, unless they're again interested in maintaining it. Then we can merge this.

@markus1189
Copy link
Contributor Author

Removed @viric for now from maintainers list

@FRidh FRidh merged commit 406e9d2 into NixOS:master May 11, 2018
@markus1189 markus1189 deleted the googleearth branch May 19, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants