Nom #124
Merged
Nom #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ekleog
force-pushed
the
nom
branch
3 times, most recently
from
59cd55d
to
658c69d
Compare
|
I'd like to merge this, but:
|
|
Done, thanks for the I've checked after the rebase, and |
|
LGTM I will merge this in the next couple days. I'm going to be traveling starting in 10min so I don't want to deeploy it now :) |
|
Great, thanks! Have a nice trip :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly rewrites the comment parser to use nom.
I've also added the
nixos-testalias fortest, and bumpedCargo.lockon my way there. If you want me to separate one of these modifications to a separate PR, just tell me!Also, currently the dependency on
nomis on its master branch: on my way there I hit a bug in nom, that will have to wait for4.0.0-beta3to be released before it's available on crates.io.