linux: enable support for iGVT-g VGPU #40242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this everything we need for that to work? How about qemu version/features? |
|
@andir Yes, that's all. Qemu 2.12 is already in nixos-unstable built with necessary features. |
|
@GrahamcOfBorg build phodav spice-gtk |
|
Success on x86_64-linux (full log) Attempted: phodav, spice-gtk Partial log (click to expand)
|
|
No attempt on x86_64-darwin (full log) The following builds were skipped because they don't evaluate on x86_64-darwin: phodav, spice-gtk Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: phodav, spice-gtk Partial log (click to expand)
|
danbst
reviewed
May 25, 2018
| vgpuOptions = { | ||
| uuid = mkOption { | ||
| type = types.string; | ||
| description = "UUID of VGPU device."; |
There was a problem hiding this comment.
Probably add some info where to get this UUID, even if it can be randomly generated.
danbst
reviewed
May 25, 2018
| in { | ||
| options = { | ||
| virtualisation.kvmgt = { | ||
| enable = mkEnableOption "KVMGT (iGVT-g) VGPU support."; |
There was a problem hiding this comment.
While technically correct, maybe add some info what this is about. Like, "allows virtual guests to share host's graphics card. Currently only one graphical device can be shared"
danbst
reviewed
May 25, 2018
| device = mkOption { | ||
| type = types.string; | ||
| default = "0000:00:02.0"; | ||
| description = "PCI ID of graphics card."; |
There was a problem hiding this comment.
Would be extremely cool if this description showed how to get that PCI ID. Otherwise one have to resort to google...
|
@danbst Done, thanks! |
GrahamcOfBorg
added
10.rebuild-linux: 0
and removed
6.topic: nixos
8.has: module (update)
10.rebuild-linux: 501+
labels
|
@matthewbauer Thanks! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Intel GVT-g (KVMGT) is a full GPU virtualization solution with mediated pass-through which allows host and multiple KVM guests to share same Intel integrated videocard. Guest gets a near-native graphics peformance.
This PR adds missing kernel configuration options. See https://nixos.wiki/wiki/IGVT-g
It also adds module which simplifies setup:
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)