Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slang: 2.3.1a -> 2.3.2 #40274

Merged
merged 2 commits into from May 10, 2018
Merged

slang: 2.3.1a -> 2.3.2 #40274

merged 2 commits into from May 10, 2018

Conversation

peterhoeg
Copy link
Member

Motivation for this change

ncurses was updated in edf2015 to 6.1 which caused slang to break on 256 color terminals. One example is mc:

~ $ mc  
Unknown terminal: screen-256color
Check the TERM environment variable.
Also make sure that the terminal is defined in the terminfo database.
Alternatively, set the TERMCAP environment variable to the desired
termcap entry.

This fixes it (at least for mc but presumable others). The mc change here is super tiny - I thought if we were going to rebuild it anyway due to slang, we might as well clean it up all little.

Cc: @Fuuzetsu @svanderburg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: mc, slang

Partial log (click to expand)

/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/image.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/package.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/sound.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/video.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/doc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/misc.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/text.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/libexec/mc/ext.d/web.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20/etc/mc/edit.indent.rc: interpreter directive changed from " /bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/qiyvdl16v5xqw22017v9r841hpddm115-mc-4.8.20...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: mc, slang

Partial log (click to expand)

/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/u7z: interpreter directive changed from " /bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/trpm: interpreter directive changed from " /bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/rpm: interpreter directive changed from " /bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/patchsetfs: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/gitfs+: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/changesetfs: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20/libexec/mc/extfs.d/bpp: interpreter directive changed from " /bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20...
/nix/store/v2zhpsmkm4lhr1xigwkmlbzmyhk7xkj3-mc-4.8.20
/nix/store/wqdxgm4rahvnxaac8jc1i31wysg0fazm-slang-2.3.2

@FRidh FRidh merged commit dbd148d into NixOS:master May 10, 2018
@peterhoeg peterhoeg deleted the u/slang branch May 10, 2018 10:45
@peterhoeg peterhoeg restored the u/slang branch May 10, 2018 12:35
@peterhoeg peterhoeg deleted the u/slang branch October 8, 2018 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuuzetsu Fuuzetsu Fuuzetsu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @GrahamcOfBorg @Fuuzetsu @FRidh