nixos/tests/mysqlbackup: fix non-deterministic failure #40258
Conversation
|
@GrahamcOfBorg eval |
nixos/tests/mysql-backup.nix
Outdated
| @@ -23,17 +23,24 @@ import ./make-test.nix ({ pkgs, ... } : { | |||
| testScript = | |||
| '' startAll; | |||
|
|
|||
| # delete backup file that may be left over from a previous run | |||
| $master->execute("rm -f /var/backup/mysql/testdb.gz"); | |||
There was a problem hiding this comment.
In case the service run just before the test or when does it happen?
There was a problem hiding this comment.
This is not necessary on Hydra. It's useful for repeated test runs on a local machine using nixos-test-driver because the disk image isn't rebuilt in that case and the file persists.
nixos/tests/mysql-backup.nix
Outdated
| @@ -23,17 +23,24 @@ import ./make-test.nix ({ pkgs, ... } : { | |||
| testScript = | |||
| '' startAll; | |||
|
|
|||
| # delete backup file that may be left over from a previous run | |||
| $master->execute("rm -f /var/backup/mysql/testdb.gz"); | |||
|
|
|||
| # Need to have mysql started so that it can be populated with data. | |||
| $master->waitForUnit("mysql.service"); | |||
|
|
|||
| # Wait for testdb to be populated. | |||
| $master->sleep(10); | |||
There was a problem hiding this comment.
Is there way to replace this by a command that checks if the database have been added?
There was a problem hiding this comment.
Good point, let me see..
xeji
force-pushed
the
fix-mysql-backup-test
branch
from
904fcf8
to
81b1e62
Compare
Sometimes failed because of delayed creation of the backup file.
xeji
force-pushed
the
fix-mysql-backup-test
branch
from
81b1e62
to
0b1237b
Compare
|
@GrahamcOfBorg test mysql-backup |
|
No attempt on aarch64-linux (full log) The following builds were skipped because they don't evaluate on aarch64-linux: tests.mysql-backup Partial log (click to expand)
|
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: tests.mysql-backup Partial log (click to expand)
|
|
@GrahamcOfBorg test mysqlBackup |
|
Success on aarch64-linux (full log) Attempted: tests.mysqlBackup Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: tests.mysqlBackup Partial log (click to expand)
|
Sometimes failed because of delayed creation of the backup file. (cherry picked from commit a19cc36)
Motivation for this change
Test sometimes failed on Hydra as it looked for a backup file that was not yet created.
Fixed by waiting for backup to finish and backup file to appear.