distrobuilder: init at 2018_04_28 #40240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| , makeWrapper, coreutils, gnupg, gnutar, squashfsTools}: | ||
|
|
||
| buildGoPackage rec { | ||
| name = "distrobuilder-unstable-${version}"; |
There was a problem hiding this comment.
I would just call it "distrobuilder-${version}" here. Having the date already shows it's not a stable release.
|
|
||
| goPackagePath = "github.com/lxc/distrobuilder"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
You should use fetchFromGitHub here unless the repo needs submodules.
|
|
||
| buildGoPackage rec { | ||
| name = "distrobuilder-unstable-${version}"; | ||
| version = "2018-04-28"; |
There was a problem hiding this comment.
I think we prefer to use either dashes or dots here. Otherwise upgrading doesn't work correctly.
Implement feedback
|
@matthewbauer Thank you for the feedback. Updated PR. |
megheaiulian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add distrobuilder package.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)