Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/plotinus: fix non-deterministic failures #40239

Merged
merged 1 commit into from May 10, 2018
Merged

nixos/tests/plotinus: fix non-deterministic failures #40239

merged 1 commit into from May 10, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 9, 2018

Motivation for this change

The test failed sometimes on Hydra, likely because a window didn't get focus before typing into it.

Use xdotool to make sure the right window has focus.

@xeji
nixos/tests/plotinus: fix non-deterministic failure
7914ca0 
Test failed sometimes, likely because a window didn't get focus.
@xeji xeji mentioned this pull request May 9, 2018
Closed
41 tasks
@Mic92
Copy link
Member

Mic92 commented May 10, 2018

@GrahamcOfBorg test plotinus

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.plotinus

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 61.84s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/myzfj2cxa3plz076gh83zjihib8fh12m-vm-test-run-plotinus

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.plotinus

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 50.35s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/8p745bbp2p4vmmjfn6cavwc8h3jww073-vm-test-run-plotinus

@xeji xeji merged commit 558f4b3 into NixOS:master May 10, 2018
@xeji xeji deleted the fix-plotinus-test branch May 10, 2018 17:38
xeji added a commit that referenced this pull request May 10, 2018
@xeji
nixos/tests/plotinus: fix non-deterministic failure (#40239)
f1e419f 
Test failed sometimes, likely because a window didn't get focus.

(cherry picked from commit 558f4b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @Mic92 @GrahamcOfBorg