Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell: fix build of base-compat-batteries #40250

Merged
merged 1 commit into from
May 10, 2018
Merged

haskell: fix build of base-compat-batteries #40250

merged 1 commit into from
May 10, 2018
+1 −1

Conversation

basvandijk
Copy link
Member

Motivation for this change

@peti base-compat-batteries fails to build with compilers other than the one from haskellPackages. This commit fixes that.

CC @endgame.

Things done

Tested using:

$ nix-build -A haskell.packages.ghc842.base-compat-batteries

and

$ nix-build -A haskellPackages.base-compat-batteries
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@basvandijk basvandijk requested a review from peti as a code owner May 9, 2018 21:07
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 9, 2018
@endgame
Copy link
Contributor

endgame commented May 10, 2018

Looks like you found me being a nix n00b. Thanks, I learned something today.

@peti
Copy link
Member

peti commented May 10, 2018

Good catch, thank you!

@peti peti merged commit 07dc607 into NixOS:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@basvandijk @endgame @peti @GrahamcOfBorg