treewide: remove lib.meta.enableIfAvailable #40255
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
|
@matthewbauer the tl;dr as long as we keep on switching to The idea behind But @dezgeg had some concerns that this was perhaps easy to abuse (say a supposed "optional" dep is actually "conditionally mandatory" on certain platforms, i.e. a sort dependent not independent), and now this would be the second time I'd be back-pedaling on where it should be used, so maybe its just better to push people towards things like Merge if you like :). |
|
I disagree with this Some Darwin user on IRC already asked/complained why they can't build This behaviour seriously should be reverted. |
|
I'm ok with this change, but please see #35906 (comment) on the issue.
|
Motivation for this change
This seems like a better approach than "enableIfAvailable" to me. The issue with "enableIfAvailable" is it combines two concepts: optional dependencies (usually configured by a flag) and availability, that are better left separate. This may seem convenient but it gives users less control over what packages are being built. For both packages (Nix & Systemd) using "enableIfAvailable" right now, it's pretty clear that they are being used as we normally use optional dependencies. Both "libseccomp" & "kexectools" can be left out and they will run correctly, whether each is broken or not. So, it makes more sense to make these configurable with a flag. We can still provide
libseccomp.meta.available&kexectools.meta.availableas defaults.I don't know if anyone has strong feelings in favor of enableIfAvailable. I definitely think it's an overloaded concept that shouldn't be used extensively in Nixpkgs. If necessary packages can always define their own version of enableIfAvailable, but I definitely don't think it should be included in lib.