systemd: suppress certain warnings to compile under gcc8 #40246
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Synthetica9
force-pushed
the
gcc8-systemd-fix
branch
from
65246ab to
3a395cc
Compare
|
Whoops, typo in commit message, let's rerun checks I suppose |
Synthetica9
changed the title
adrianpk
added a commit
to adrianpk/nixpkgs
that referenced
this pull request
May 31, 2024
systemd: suppress certain warnings to compile under gcc8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
systemd didn't build under gcc8. This suppresses the warnings, my prediction is that this is only needed for this systemd release and that the next release will have fixed this. I have left a note to the next person updating systemd to check this.
This was failing on Hydra (linux-x86_64) due to memory shortage, here's the (linux-aarch64) log:
https://hydra.nixos.org/build/73809444/nixlog/1
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)