Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Get rid of *Platform.arch #40272

Merged
merged 1 commit into from May 10, 2018
Merged

treewide: Get rid of *Platform.arch #40272

merged 1 commit into from May 10, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Use parsed.cpu.name or platform.gcc.arch instead.

Back-port of #40270

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 requested a review from nbp as a code owner May 10, 2018 05:17
@Ericson2314
treewide: Get rid of *Platform.arch
a02be2b 
Use `parsed.cpu.name` or `platform.gcc.arch` instead.
@Ericson2314 Ericson2314 force-pushed the lib-platform-simplify-18.03 branch 2 times, most recently from 4440ada to a02be2b Compare May 10, 2018 05:42
@Ericson2314 Ericson2314 merged commit 45cd609 into NixOS:release-18.03 May 10, 2018
@Ericson2314 Ericson2314 deleted the lib-platform-simplify-18.03 branch May 10, 2018 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg