Improving smartjoin for non-strings (#3080) #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralsina
reviewed
May 9, 2018
nikola/utils.py
Outdated
| """ | ||
| if isinstance(string_or_iterable, (unicode_str, bytes_str)): | ||
| return string_or_iterable | ||
| if hasattr(string_or_iterable, '__iter__'): |
There was a problem hiding this comment.
Ooops. That was stupid :)
felixfontein
force-pushed
the
improve-smartjoin
branch
from
5b7e800
to
9eccdbf
Compare
Kwpolska
approved these changes
May 9, 2018
nikola/utils.py
Outdated
| """ | ||
| if isinstance(string_or_iterable, (unicode_str, bytes_str)): | ||
| return string_or_iterable | ||
| elif hasattr(string_or_iterable, '__iter__'): |
There was a problem hiding this comment.
isinstance(string_or_iterable, collections.Iterable) would look nicer IMO
There was a problem hiding this comment.
Is this actually equivalent?
There was a problem hiding this comment.
Good to know. I changed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3080.