Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs: init at v10.0.0 #39564

Merged
merged 2 commits into from Apr 27, 2018
Merged

nodejs: init at v10.0.0 #39564

merged 2 commits into from Apr 27, 2018

Conversation

SergeL
Copy link
Contributor

@SergeL SergeL commented Apr 26, 2018 •
edited

Motivation for this change

release notes

As node 10 requires libuv 1.20.2 this PR goes against staging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I've just started builds locally on darwin and nixOS but this probably takes few hours.

I'll update the checkboxes above, when the builds are done.

@adisbladis adisbladis merged commit e9841a6 into NixOS:staging Apr 27, 2018
@adisbladis
Copy link
Member

I was just doing the same thing :)
Thanks for your first contribution to nixpkgs! Welcome on board. 🥂

@lo1tuma lo1tuma deleted the nodejs-10 branch April 27, 2018 06:48
@SergeL
Copy link
Contributor Author

SergeL commented Apr 27, 2018

@adisbladis thank you 😄

@svanderburg
Copy link
Member

svanderburg commented Apr 27, 2018 •
edited

Great work! I was just packaging it myself, before I realized that someone else had done it.

I just made a small modification to also apply the no-xcodebuild patch. Without it, modules with native dependencies (such as hiredis) will not build properly on macOS: abbf965

@SergeL
Copy link
Contributor Author

SergeL commented Apr 27, 2018

@svanderburg thank you very much for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SergeL @adisbladis @svanderburg @GrahamcOfBorg @Janik-Haag