Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owncloud-client: 2.3.4 -> 2.4.1 #39566

Merged
merged 1 commit into from May 9, 2018
Merged

owncloud-client: 2.3.4 -> 2.4.1 #39566

merged 1 commit into from May 9, 2018

Conversation

bfortz
Copy link
Contributor

@bfortz bfortz commented Apr 26, 2018

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Apr 26, 2018
View reviewed changes
pkgs/applications/networking/owncloud-client/default.nix
};

patches = [ ../nextcloud-client/find-sql.patch ];
patches = [ ./find-sql.patch ];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind opening a pull request in the upstream repo and adding a link here as a comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... I made the version bump based on the 2.3.4 version currently in 18.03 stable. This is based on the Enterprise Version from owncloud.com, but there is no way to pull requests. The opensource Standard Edition is the one you mention as upstream repo but it has a different structure and the patch above does not apply. Should we switch to the Standard Edition? (It seems the Enterprise Version has more features, but I don't really care as I'm using only basic functionalities). Maybe @qknight has a take on this?

@bfortz
Copy link
Contributor Author

bfortz commented May 5, 2018

Any hope to have this merged?

@xeji
Copy link
Contributor

xeji commented May 9, 2018

@GrahamcOfBorg build owncloud-client

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: owncloud-client

Partial log (click to expand)

shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64/libowncloudsync.so.2.4.1
shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin/owncloud
shrinking /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin/owncloudcmd
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64  /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/bin
patching script interpreter paths in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1
checking for references to /build in /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1...
moving /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib64/* to /nix/store/67i3mp5l9v8bs1w1bngvap7a2c0z9l5c-owncloud-client-2.4.1/lib
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: owncloud-client

Partial log (click to expand)

  "Qt5MacExtras" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:218 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-owncloud-client-2.4.1.drv-0/owncloudclient-2.4.1/build/CMakeFiles/CMakeOutput.log".
builder for '/nix/store/iyriz96wpkhahvsj9pipkslwg5zwp0v0-owncloud-client-2.4.1.drv' failed with exit code 1
error: build of '/nix/store/iyriz96wpkhahvsj9pipkslwg5zwp0v0-owncloud-client-2.4.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: owncloud-client

Partial log (click to expand)

shrinking /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/libowncloudsync.so.2.4.1
shrinking /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/owncloud/libocsync.so.2.4.1
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64  /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/bin
patching script interpreter paths in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1
checking for references to /build in /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1...
moving /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib64/* to /nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1/lib
postPatchMkspecs
postPatchMkspecs
/nix/store/cngv6j2vk8q4pm423ads8p8i4rrchghb-owncloud-client-2.4.1

@xeji xeji merged commit 96c2cad into NixOS:master May 9, 2018
@bfortz bfortz deleted the owncloud-2.4.1 branch May 21, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bfortz @xeji @GrahamcOfBorg @jtojnar