Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: f1f2c7292ac8
Choose a base ref
...
head repository: jruby/jruby
compare: ac66a74a66b7
Choose a head ref
  • 4 commits
  • 15 files changed
  • 1 contributor

Commits on Apr 26, 2018

  1. Fix a couple of syntax errors in parser.

    @enebo
    enebo committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    e445827 View commit details
    Browse the repository at this point in the history

  2. Removal of old isSingleton counter for isInClass.

    @enebo
    enebo committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    e3d52ba View commit details
    Browse the repository at this point in the history

  3. Yay. Ruby made some errors statically fail. For next,break,redo: 

      - will fail in top-level scope as SyntaxError instead of LJE
  - will fail in eval as SyntaxError (we largely did something weird)

In addition, yield will fail in toplevel scope with a SyntaxError.

This change is great but we still have an outstanding issue. We IRBuild method
bodies on demand.  So this will throw a syntaxerror much later than MRI. This
can be worked around but if we want to keep laziness we will need to mark
non-lazy methods which contain these keywords and compile those eagerly.  Also
we need to do that without rewalking the planet to look for those nodes.
    @enebo
    enebo committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    4b1279e View commit details
    Browse the repository at this point in the history

  4. exclude test due to us being clever :P (we lazily compile method bodies)

    @enebo
    enebo committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    ac66a74 View commit details
    Browse the repository at this point in the history