Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm5: 5.0.1 -> 5.0.2 #39979

Merged
merged 1 commit into from May 5, 2018
Merged

llvm5: 5.0.1 -> 5.0.2 #39979

merged 1 commit into from May 5, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 4, 2018

Spectre-related fixes.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented May 4, 2018

@NixOS/darwin-maintainers okay to merge to staging for testing/rebuilds?

@LnL7
Copy link
Member

LnL7 commented May 4, 2018

Probably fine, but I'll start a build to check there are no obvious issues.

@matthewbauer
Copy link
Member

matthewbauer commented May 4, 2018 •
edited

Yeah this looks like a patch release and okay to merge quickly.

BTW Has anyone looked into moving to LLVM6?

@dtzWill
Copy link
Member Author

dtzWill commented May 4, 2018

Haha, you know I have! https://github.com/dtzWill/nixpkgs/tree/update/llvm-6-default (think created that shortly after LLVM6 was in-tree, so it's a bit old)

I forget if I found any problems, though.

It would save rebuilds to move to 6 directly instead of 5.0.2. 6.0.1 is due in a month or so, but usually point releases are easy: no breakage, just the rebuilds.

@dtzWill
Copy link
Member Author

dtzWill commented May 4, 2018 •
edited

Rebased that branch onto staging here: https://github.com/dtzWill/nixpkgs/tree/update/llvm-6-default-rebased FWIW.

EDIT: actually I just made a PR that changes the default: #39986

@LnL7 LnL7 merged commit 8994bf5 into NixOS:staging May 5, 2018
@vcunat
Copy link
Member

vcunat commented May 6, 2018

Is there some description of what's changed? Upstream has nothing on the web/announcement ML (yet?)

vcunat pushed a commit that referenced this pull request May 8, 2018
@LnL7 @vcunat
Merge #39979: llvm5: 5.0.1 -> 5.0.2
ff510fd 
(cherry picked from commit 8994bf5)
vcunat added a commit that referenced this pull request May 8, 2018
@vcunat
Revert "Merge #39979: llvm5: 5.0.1 -> 5.0.2"
08aea7c 
This reverts commit ff510fd.
Moved to staging-18.03; I didn't intend to have this in 18.03 *yet*.
vcunat added a commit that referenced this pull request May 8, 2018
@vcunat
Re-revert "Merge #39979: llvm5: 5.0.1 -> 5.0.2"
7dde651 
This reverts commit 08aea7c.
xeji added a commit to xeji/nixpkgs that referenced this pull request May 17, 2018
@xeji
faust2: fix build with llvm 5.0.2
e9c135a 
build was broken by  llvm: 5.0.1 -> 5.0.2 (NixOS#39979)
This was referenced May 17, 2018
Merged
Closed
xeji added a commit that referenced this pull request May 21, 2018
@xeji
faust2: fix build with llvm 5.0.2 (#40672)
a16c312 
build was broken by  llvm: 5.0.1 -> 5.0.2 (#39979)
xeji added a commit that referenced this pull request Jun 5, 2018
@xeji
faust2: fix build with llvm 5.0.2 (#40672)
44f3a1d 
build was broken by  llvm: 5.0.1 -> 5.0.2 (#39979)

(cherry picked from commit a16c312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @LnL7 @matthewbauer @vcunat @GrahamcOfBorg