Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/powerManagement: add "med_power_with_dipm" scsiLinkPolicy #39982

Merged
merged 1 commit into from May 22, 2018

Conversation

tadfisher
Copy link
Contributor

Motivation for this change

Linux kernels 4.15-rc1 and newer added a "med_power_with_dipm" option for SATA link policy management. This is intended for devices which are not stable under "min_power" but need certain LPM features enabled to save power.

Some background:

This change adds this new option to config.powerManagement.scsiLinkPolicy, and asserts the system is configured to boot with 4.15 or later if this option is set.

It might be desirable to set this as default for kernels 4.15 and newer, as in the newer Fedora kernels. Power savings is nearly as good as "min_power" with much better stability, as seen here: https://fedoraproject.org/wiki/Changes/ImprovedLaptopBatteryLife#User_Experience. In the past, "min_power" was the NixOS default but this was reverted due to stability issues for users; see #11276.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants