Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplescreenrecorder: port to qt5 #39974

Merged
merged 1 commit into from May 4, 2018
Merged

simplescreenrecorder: port to qt5 #39974

merged 1 commit into from May 4, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 4, 2018 •
edited

Motivation for this change

See #33248

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: simplescreenrecorder

Partial log (click to expand)

../glinject/elfhacks.h:67:3: error: #error neither __elf32 nor __elf64 is defined
 # error neither __elf32 nor __elf64 is defined
   ^~~~~
[3/55] Building CXX object glinject/CMakeFiles/ssr-glinject.dir/GLInject.cpp.o
[4/55] Building CXX object glinject/CMakeFiles/ssr-glinject.dir/GLXFrameGrabber.cpp.o
[5/55] Building CXX object glinject/CMakeFiles/ssr-glinject.dir/SSRVideoStreamWriter.cpp.o
[6/55] Automatic MOC for target simplescreenrecorder
ninja: build stopped: subcommand failed.
builder for '/nix/store/92ipkhyaa5wyjqxpjdfkxykh89xs01ak-simplescreenrecorder-0.3.10.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/92ipkhyaa5wyjqxpjdfkxykh89xs01ak-simplescreenrecorder-0.3.10.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: simplescreenrecorder

Partial log (click to expand)

shrinking /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin/simplescreenrecorder
shrinking /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/lib/libssr-glinject.so
gzipping man pages under /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/lib  /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin
patching script interpreter paths in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10
/nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin/ssr-glinject: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10...
postPatchMkspecs
/nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10

@xeji
Copy link
Contributor

xeji commented May 4, 2018

Works fine here. As far as Hydra logs go, this package never built on aarch64, so why don't we restrict it to x86_64-linux ?

@Ma27
Copy link
Member Author

Ma27 commented May 4, 2018

@xeji you're right, fixed that :-)

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: simplescreenrecorder

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: simplescreenrecorder

Partial log (click to expand)

shrinking /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/lib/libssr-glinject.so
shrinking /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin/simplescreenrecorder
gzipping man pages under /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/lib  /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin
patching script interpreter paths in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10
/nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10/bin/ssr-glinject: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10...
postPatchMkspecs
/nix/store/hdizf4c7rw4d6yrw4yqq1l3x2z29hws4-simplescreenrecorder-0.3.10

@xeji xeji merged commit da69dc4 into NixOS:master May 4, 2018
@Ma27 Ma27 deleted the ssr-qt5 branch May 4, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji