Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minitube: 2.4 -> 2.9 #39977

Merged
merged 1 commit into from
May 4, 2018
Merged

minitube: 2.4 -> 2.9 #39977

merged 1 commit into from
May 4, 2018
+10 −7

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 4, 2018 •
edited
Loading

Motivation for this change

Version 2.9 is based on QT5 (with a much better interface) and requires
additionally the dependencies qtbase, qtdeclarative and qttools.

Furthermore the QT_PLUGIN_PATH had to be altered, however the
phonon-backend contains versioned paths, so we provide the plugin path
that matches the QT version used to build this package.

See #33248

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ma27
minitube: 2.4 -> 2.9
39c6332 
Version 2.9 is based on QT5 (with a much better interface) and requires
additionally the dependencies `qtbase`, `qtdeclarative` and `qttools`.

Furthermore the `QT_PLUGIN_PATH` had to be altered, however the
`phonon-backend` contains versioned paths, so we provide the plugin path
that matches the QT version used to build this package.

See NixOS#33248
@xeji
Copy link
Contributor

xeji commented May 4, 2018 •
edited
Loading

When I build and run this locally, it seems to work fine but I get these error messages:

$ result/bin/minitube 
[unknown] QIODevice::read (QFile, ":/functions.js"): device not open
[00007f68e0000c28] vdpau_avcodec generic error: Xlib is required for VDPAU

The second one is probably not related to this package, but the first one might be.

@Ma27
Copy link
Member Author

Ma27 commented May 4, 2018

@xeji I get the vdpau_avcodec error as well, but do you know something about the first one? Neither @WilliButz nor I get the first error with QIODevice.

@xeji
Copy link
Contributor

xeji commented May 4, 2018

The first error seems to be generated here in the source but I don't know anything else about it.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 4, 2018
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: minitube

Partial log (click to expand)

copying path '/nix/store/qmy3scdwr360w7ndly8hvjv5523ngx3x-qttools-5.10.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/fb415hlj4pkx6l9i0wmbinslc0l6c4ji-phonon-qt5-4.9.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/fcilava2s8xjwingfws0djjbxd71vxg9-qttools-5.10.1-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/mip9360ljai70i4rm4wfiflrxkgmfja6-ffmpeg-2.8.13-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/hxj676h7lf6mxivladwkl66l4qrirvyr-ffmpeg-2.8.13-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/4x7js8w6caq50a9223j0n56dw1mf6isb-samba-4.7.6-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/w2gi5gf9v79pplwpgqjq6cpbv281mmlc-vlc-2.2.8.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/kymvbka65icgfzjp4mbv6k00z88maq62-phonon-backend-vlc-qt5-0.9.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bp32ni5l98hi8rqrnm1q217lyz33c6v3-minitube-2.9.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/bp32ni5l98hi8rqrnm1q217lyz33c6v3-minitube-2.9.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: minitube

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9
shrinking /nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9/bin/.minitube-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9/bin
patching script interpreter paths in /nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9
checking for references to /build in /nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9...
postPatchMkspecs
postPatchMkspecs
/nix/store/nvzbppw85rqff0i5h0p9cawbmjccxsr2-minitube-2.9

@Ma27
Copy link
Member Author

Ma27 commented May 4, 2018

@xeji did you encounter any issues while using this package? I tried playing around with it a bit and besides the probably unrelated vdpau_avcodec generic error: Xlib is required for VDPAU error no errors arise and the application works fine.

Interestingly enough the qt4 variant (v2.4) broke for me with the following errors:

[0000000002a8b6b8] core input error: Your input can't be opened
[0000000002a8b6b8] core input error: VLC is unable to open the MRL 'https://r2---sn-4g5e6nsk.googlevideo.com/videoplayback?ipbits=0&fexp=23724337&dur=213.623&mime=video%2Fmp4&itag=18&source=youtube&mm=31%2C26&mn=sn-4g5e6nsk%2Csn-25ge7nsl&requiressl=yes&ip=2a00%3Acb0%3A8002%3A1055%3Aca5b%3A76ff%3Afeca%3Ad3c5&gir=yes&ratebypass=yes&fvip=6&mt=1525462356&mv=u&pl=34&id=o-AB_szYNuSyeBAYSWlJmrYpJWbFI7_d6C6zX-mV9oIn1G&ei=xLfsWvbaLNDbgQf03bqQDA&ms=au%2Conr&c=WEB&key=yt6&lmt=1524755502570017&clen=19154330&expire=1525484580&sparams=clen%2Cdur%2Cei%2Cgir%2Cid%2Cip%2Cipbits%2Citag%2Clmt%2Cmime%2Cmm%2Cmn%2Cms%2Cmv%2Cpl%2Cratebypass%2Crequiressl%2Csource%2Cexpire&signature=undefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefinedundefined'. Check the log for details.
Phonon error: "No active input"  Phonon::NormalError

I'm unfortunately unable to estimate how serious the error is you described, so I'm unsure if we should merge for now or try further investigation (in case the application is unusable for you) :-)

@xeji
Copy link
Contributor

xeji commented May 4, 2018

Seems to work just fine here, and the first error has disappeared too. Looks like it was caused by a nonexisting file ~/.local/share/Flavio Tordini/Minitube/functions.js on startup, which the app seems to create later when you actually watch a video. aarch64 failure is in a dependency, so I think this is good to merge.

@xeji xeji merged commit 5c63fbd into NixOS:master May 4, 2018
@Ma27 Ma27 deleted the update-minitube branch May 4, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @xeji @GrahamcOfBorg