Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed name from Scapy #39058

Merged
merged 1 commit into from Apr 17, 2018
Merged

Removed name from Scapy #39058

merged 1 commit into from Apr 17, 2018

Conversation

Synthetica9
Copy link
Member

This is automatically done by pname and version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 requested a review from FRidh as a code owner April 17, 2018 10:23
dotlambda
dotlambda requested changes Apr 17, 2018
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please format your commit message according to the guidelines, e.g.

pythonPackages.scapy: remove name attribute

@Synthetica9
Copy link
Member Author

@dotlambda ✔️

@dotlambda dotlambda merged commit 0ebf6ad into NixOS:master Apr 17, 2018
@Synthetica9 Synthetica9 deleted the patch-1 branch April 17, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @dotlambda @GrahamcOfBorg