Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: fix rename.nix bugs #39048

Merged
merged 2 commits into from Apr 22, 2018
Merged

nixos: fix rename.nix bugs #39048

merged 2 commits into from Apr 22, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Apr 17, 2018

Motivation for this change

I think this should be a proper fix to #34253 (comment) of #34253. It is a bug I introduced myself.
/cc @fpletz

Things done

@oxij
Revert "nixos/version: fix nixops pre 1.6 compatibility"
4018d44 
This reverts commit 70c6f65.
@oxij
nixos: rename.nix: fix bugs
b57a6e9 
Introduced in 286b007 and then
in 2e6b796.

This a proper fix for what 70c6f65 tried to do.
Removing the "config" prefix triggers the bug on pure nixos too, not only
on nixops.
@oxij oxij changed the title Nixos/fix rename bugs nixos: fix rename.nix bugs Apr 17, 2018
@oxij
Copy link
Member Author

oxij commented Apr 19, 2018

ping

@oxij
Copy link
Member Author

oxij commented Apr 22, 2018

/cc @ttuegel since your code is involved here, @joachifm as a common editor of the file, and @vcunat and @Ericson2314 for general wisdom on the topic

@oxij oxij mentioned this pull request Apr 22, 2018
Closed
@joachifm joachifm merged commit f442bfc into NixOS:master Apr 22, 2018
@oxij
Copy link
Member Author

oxij commented Apr 22, 2018 via email

@oxij oxij deleted the nixos/fix-rename-bugs branch September 8, 2018 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @joachifm @GrahamcOfBorg