error message honores nested dots in attribute path elements #39060
Conversation
while using submodules we encountered that if the value is used but was not assigned one would see this incorrect error message: error: The option `nixcloud.TLS.certs.example.com.mode' is used but not defined. this patch fixes it to: error: The option `nixcloud.TLS.certs."example.com".mode' is used but not defined. please also backport to 18.03
|
This is in a bit of a weird state. It looks like commit 059a71a intended to fix this same problem. As of right now (19.03.173059.799a080ba1b (Koi)), the problem still exists, but this pull request is in conflict. I would like some input from @grahamc, since he worked on the committed fix, and I'm not totally sure how that is intended to work. I think the change to the current code would only need to be how we determine if we use the escaped string or the original string. Unless there is already a function to do this, we could probably use a function to check if the string contains ".", similar to this pull request. |
|
This pull request has been mentioned on Nix community. There might be relevant details there: |
|
@blargg In that case I'd recommend opening a new issue with your concerns. |
while using submodules we encountered that if the value is used but was not assigned
one would see this incorrect error message:
error: The option `nixcloud.TLS.certs.example.com.mode' is used but not defined.
this patch fixes it to:
error: The option `nixcloud.TLS.certs."example.com".mode' is used but not defined.
please also backport to 18.03
note
i've checked this patch locally, see the error message. if wanted i can prepare a minimal example how to reproduce.