firewall service: respect marks in rpfilter #39054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows one to add rules which change a packet's routing table: iptables -t raw -I PREROUTING 1 -m set --match-set myset src -j MARK --set-mark 2 ip rule add fwmark 2 table 1 priority 1000 ip route add default dev wg0 table 1 to the beginning of raw table PREROUTING chain, and still have rpfilter.
Mic92
approved these changes
Apr 17, 2018
Mic92
reviewed
Apr 17, 2018
| @@ -123,7 +123,7 @@ let | |||
| # Perform a reverse-path test to refuse spoofers | |||
| # For now, we just drop, as the raw table doesn't have a log-refuse yet | |||
There was a problem hiding this comment.
This comment is out-of-date if you check line 134.
There was a problem hiding this comment.
Yeah, I thought of getting rid of it too -- will do.
There was a problem hiding this comment.
It is a bit strange that nixos does rpfilter with netfilter since Linux already check reverse path with net.ipv4.conf.all.rp_filter
There was a problem hiding this comment.
IMO this is fine. Using validmark shouldn't cause any (additional) trouble.
I don't think it is an issue using the rpfilter mod in conjunction with the sysctl. It is the only option for IPv6 anyway.
|
Any news on this? If this is still relevant it would be nice to get it into 18.09. |
xeji
approved these changes
Aug 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This allows one to add rules which change a packet's routing table:
to the beginning of raw table PREROUTING chain, and still have rpfilter. One use case is routing packets to specific IP addresses through other network interface (I use this to route packets to hosts blocked in Russia through VPN).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)