Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify installation steps w.r.t. disk partitions #39066

Merged
merged 1 commit into from Apr 17, 2018

Conversation

ckauhaus
Copy link
Contributor

Motivation for this change

The steps in the manual don't work if typed exactly as described.

Things done
  • mkfs.fat needs -n to set a partition label, not -L.
  • Create /mnt/boot before mounting.
  • Leave out detailed LVM example. Advanced users already how to create LVs, while it might be detracting for novices.

Fixes #38674

- mkfs.fat needs `-n` to set a partition label, not `-L`.
- create /mnt/boot before mounting
- leave out detailed LVM example as advanced users already how to create
  LVs while it is detracting for novices.

Re NixOS#38674
<replaceable>label</replaceable></option>. For example:

<screen>
# mkfs.fat -F 32 -L boot /dev/sda3</screen>
# mkfs.fat -F 32 -n boot /dev/sda3</screen>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should boot be changed to BOOT, or is the warning identified in the ticket not a problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower-case FAT partition labels are a problem for windows, but not for Linux. We could make sure and use BOOT everywhere. It is not necessary technically, but won't lead to a warning which might distract novice users.

@grahamc grahamc merged commit 1f4cf80 into NixOS:master Apr 17, 2018
@ckauhaus ckauhaus deleted the submit/38674-installdocs-mkfs branch April 17, 2018 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants