Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freerdp: 2.0.0-rc1 -> 2.0.0-rc2 #39077

Closed
wants to merge 1 commit into from
Closed

freerdp: 2.0.0-rc1 -> 2.0.0-rc2 #39077

wants to merge 1 commit into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Apr 17, 2018 •
edited

Motivation for this change

Old version fails on connecting to recently patched windows systems with strange ERRCONNECT_PASSWORD_CERTAINLY_EXPIRED error message.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tokudan
Copy link
Contributor Author

tokudan commented Apr 17, 2018

I've tested xfreerdp and it "works for me".

Mentioning the maintainers... @wkennington @peterhoeg

@Mic92 Mic92 mentioned this pull request Apr 17, 2018
Closed
8 tasks
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

Duplicate of #38886
However this pull request has the correct checksum.

@Mic92 Mic92 changed the title freerdp 2.0.0-rc1 -> 2.0.0-rc2 freerdp: 2.0.0-rc1 -> 2.0.0-rc2 Apr 17, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build freerdp

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: freerdp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

shrinking /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib/libfreerdp-client2.so.2.0.0
shrinking /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib/libuwac0.so.0.0.1
shrinking /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib/libfreerdp2.so.2.0.0
shrinking /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib/libwinpr-tools2.so.2.0.0
shrinking /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib/libwinpr2.so.2.0.0
gzipping man pages under /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/lib  /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2/bin
patching script interpreter paths in /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2
checking for references to /build in /nix/store/3sdqmq694jh2bkf5szgbdbiwzcz3l47y-freerdp-2.0.0-rc2...

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: freerdp

Partial log (click to expand)

shrinking /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin/xfreerdp
shrinking /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin/wlfreerdp
shrinking /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin/freerdp-shadow-cli
shrinking /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin/winpr-hash
shrinking /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin/winpr-makecert
gzipping man pages under /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/lib  /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2/bin
patching script interpreter paths in /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2
checking for references to /build in /nix/store/vwvqil0i863ryhpnh2kyjkyb2qf3qdn6-freerdp-2.0.0-rc2...

@snaar
Copy link
Contributor

snaar commented Apr 17, 2018

It would be great if this is also available in 18.03 branch.

@peterhoeg peterhoeg closed this Apr 19, 2018
@peterhoeg
Copy link
Member

Fixed in da46950

@peterhoeg peterhoeg mentioned this pull request Apr 19, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tokudan @Mic92 @GrahamcOfBorg @snaar @peterhoeg