Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gflags: alias to google-gflags #39075

Merged
merged 1 commit into from Apr 17, 2018
Merged

gflags: alias to google-gflags #39075

merged 1 commit into from Apr 17, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 17, 2018 •
edited

Motivation for this change

Both packages referred to the same repo (gflags/gflags at GitHub),
both packages used almost the same version (2.2.1 and 2.2.0). Therefore
I think that it's just fair to drop one of the packages to avoid
duplication and reduce the maintenance overload.

I decided to drop gflags originally packaged by @shlevy as it didn't
contain testing support as google-gflags does. The package set refers
from gflags to google-gflags, so both package names remain (to avoid
any confusions), however the gflags expression is removed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
gflags: alias to google-gflags
6c01c7f 
Both packages referred to the same repo (`gflags/gflags` at GitHub),
both packages used almost the same version (2.2.1 and 2.2.0). Therefore
I think that it's just fair to drop one of the packages to avoid
duplication and reduce the maintenance overload.

I decided to drop `gflags` originally packaged by @shlevy as it didn't
contain testing support as `google-gflags` does. The package set refers
from `gflags` to `google-gflags`, so both package names remain (to avoid
any confusions), however the `gflags` expression is removed.
@Ma27
Copy link
Member Author

Ma27 commented Apr 17, 2018

currently running nox-review, it might take a bit time though.....

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build gflags

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gflags

Partial log (click to expand)

-- Installing: /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/lib/cmake/gflags/gflags-targets.cmake
-- Installing: /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/lib/cmake/gflags/gflags-targets-release.cmake
-- Installing: /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/bin/gflags_completions.sh
-- Installing: /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/lib/pkgconfig/gflags.pc
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/lib  /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1
/nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash"
/nix/store/nq8d414sx5mlc253fh87a7wq1d897jxb-google-gflags-2.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gflags

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1
shrinking /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1/lib/libgflags_nothreads.so.2.2.1
shrinking /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1/lib/libgflags.so.2.2.1
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1/lib  /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1
/nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1...
/nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gflags

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1
shrinking /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1/lib/libgflags_nothreads.so.2.2.1
shrinking /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1/lib/libgflags.so.2.2.1
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1/lib  /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1/bin
patching script interpreter paths in /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1
/nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1/bin/gflags_completions.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1...
/nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1

@Mic92 Mic92 merged commit 4b7abf3 into NixOS:master Apr 17, 2018
@Ma27 Ma27 deleted the fix-gflags-package-duplication branch April 17, 2018 15:42
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gflags

Partial log (click to expand)

/nix/store/sj3smj1ra5bjw68nardciwdhdcc441w2-google-gflags-2.2.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gflags

Partial log (click to expand)

/nix/store/r6pgrqz3yrhkjmm5bcllygzanj734vrd-google-gflags-2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @Mic92 @GrahamcOfBorg