Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: HTML Validity Tests #2317

Merged
merged 9 commits into from Oct 31, 2019
Merged

WIP: HTML Validity Tests #2317

merged 9 commits into from Oct 31, 2019

Conversation

splitbrain
Copy link
Collaborator

@splitbrain splitbrain commented Apr 17, 2018

This implements a framework to automatically check our HTML for validity as suggested by @selfthinker

This is very sparse for now and need some more fixes

splitbrain and others added 6 commits April 17, 2018 16:30
Checks are done against the w3.org validator API. Currently we have some
fails. One will be fixed in #2314, others still need to be fixed.

This integration test also reveals some code bugs because texts do not
suppress warnings and deprecation messages.
The code would previously throw a warning when a changelog did not exist
or was empty.
* master:
  fix(search): don't start result position with 2
  refactor(search): clearer data flow
  Change spacing in search meta data to punctuation
  translation update
  translation update
  Fix(search): restore valid heading hierarchy
  fix(search): add position to fulltext results event
  fix(search): ensure consistent html in search results
  Fix invalid HTML in search results
  Fix links with invalid empty target attributes
  Fix buttons with invalid empty name attributes
* recenttypefix:
  Honor type setting for recent changes. fixes #2322
@splitbrain splitbrain added this to Triage in PSR-2 Finishing via automation Oct 10, 2019
@splitbrain splitbrain moved this from Triage to Needs Work in PSR-2 Finishing Oct 15, 2019
* master: (492 commits)
  Avoid flaky tests by waiting full seconds
  translation update
  translation update
  translation update
  translation update
  Check for null JS object on form field.
  translation update
  Rename _acl_add to _acl_addOrUpdate
  Fix #1115
  translation update
  translation update
  translation update
  Update config.class.php
  translation update
  translation update
  use inline template instead of .dist file to populate users.auth.php
  authpdo: fix _query return type issue per Scrutinizer inspection
  Update lang.php
  Add ugc hint to nofollow
  add UGC hint
  ...
Because we use an online validator
@splitbrain
Copy link
Collaborator Author

Validation fails because of #2855 seems like the validator doesn't know about rel="ugc" yet.

We use the ugc (user generated content) value for no-follow links since #2855
this is not yet supported in the validator.

This patch introduces a list of ignored error messages.
@splitbrain splitbrain merged commit fc21b37 into master Oct 31, 2019
PSR-2 Finishing automation moved this from Needs Work to Done Oct 31, 2019
@splitbrain splitbrain deleted the htmlvaliditytests branch October 31, 2019 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant