New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: HTML Validity Tests #2317
Merged
Merged
WIP: HTML Validity Tests #2317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks are done against the w3.org validator API. Currently we have some fails. One will be fixed in #2314, others still need to be fixed. This integration test also reveals some code bugs because texts do not suppress warnings and deprecation messages.
The code would previously throw a warning when a changelog did not exist or was empty.
* master: fix(search): don't start result position with 2 refactor(search): clearer data flow Change spacing in search meta data to punctuation translation update translation update Fix(search): restore valid heading hierarchy fix(search): add position to fulltext results event fix(search): ensure consistent html in search results Fix invalid HTML in search results Fix links with invalid empty target attributes Fix buttons with invalid empty name attributes
* recenttypefix: Honor type setting for recent changes. fixes #2322
splitbrain
commented
Oct 15, 2019
* master: (492 commits) Avoid flaky tests by waiting full seconds translation update translation update translation update translation update Check for null JS object on form field. translation update Rename _acl_add to _acl_addOrUpdate Fix #1115 translation update translation update translation update Update config.class.php translation update translation update use inline template instead of .dist file to populate users.auth.php authpdo: fix _query return type issue per Scrutinizer inspection Update lang.php Add ugc hint to nofollow add UGC hint ...
Because we use an online validator
Validation fails because of #2855 seems like the validator doesn't know about rel="ugc" yet. |
We use the ugc (user generated content) value for no-follow links since #2855 this is not yet supported in the validator. This patch introduces a list of ignored error messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a framework to automatically check our HTML for validity as suggested by @selfthinker
This is very sparse for now and need some more fixes
create_function()
-> New release tag GeSHi/geshi-1.0#106