nixos/tor: use RuntimeDirectory, StateDirectory #39083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Apr 17, 2018
| @@ -705,7 +705,6 @@ in | |||
|
|
|||
| # Translated from the upstream contrib/dist/tor.service.in | |||
| preStart = '' | |||
| install -o tor -g tor -d ${torDirectory}/onion ${torRunDirectory} | |||
| ${pkgs.tor}/bin/tor -f ${torRcFile} --verify-config | |||
| ''; | |||
There was a problem hiding this comment.
serviceConfig.ExecStartPre can be then used. This saves one derivation because no script has to be created. Also it generates more readable systemd units.
dotlambda
force-pushed
the
tor-runtime-dir
branch
from
09a12d7
to
3604142
Compare
dotlambda
force-pushed
the
tor-runtime-dir
branch
from
3604142
to
c182975
Compare
|
If this works, then LGTM. (I don't run systemd anymore, s6 FTW!)
|
|
If I was to write a Tor test, what would you guys think of including it in the tested jobset? I'm accessing some of my servers (located behind a NAS) using Tor instead of dynamic DNS and if I had upgraded them, I would have lost access. |
|
Something like
- start tor in a net-less VM and check for the process to come up,
- in a net-full VM (in a separate test because some countries block Tor's public nodes) check for "Bootstrapped: 100%" in the log
- create a hidden service, try to connect from another VM
?
That, indeed, would be nice.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#37827 (comment)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @oxij @offlinehacker