Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partclone: add support for various filesystems #39080

Merged
merged 1 commit into from Apr 17, 2018

Conversation

emmanuelrosa
Copy link
Contributor

Adds support for ext2/3/4, fat, hfs+, minix, nilfs, ntfs, and xfs

Closes #39079

Motivation for this change

As it stands, the partclone package does not provide support for efficient cloning of filesystems; The partclone.[fs_type] symbolic links are missing. This means that cloning is limited to partclone.dd, a bit-identical copy.

In contrast, this change adds support for some of the supported filesystems, allowing partclone to perform efficient cloning of said filesystems.

Missing filesystems

The following filesystems are not in this change because I was unable to get the configure script to detect the dependencies.

  • reiserfs
  • ufs
  • vmsf
  • jsf

In addition, I did not add FUSE support.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • [ ] macOS
    • other Linux distributions
  • [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Adds support for ext2/3/4, fat, hfs+, minix, nilfs, ntfs, and xfs

Closes NixOS#39079
@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build partclone

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: partclone

Partial log (click to expand)

shrinking /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/sbin/partclone.restore
shrinking /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/sbin/partclone.dd
shrinking /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/sbin/partclone.info
gzipping man pages under /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/sbin
patching script interpreter paths in /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11
checking for references to /build in /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11...
moving /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/sbin/* to /nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11/bin
/nix/store/swxd722615l02rh0lbj64j6wpsq74dx9-partclone-0.3.11

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: partclone

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: partclone

Partial log (click to expand)

shrinking /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/sbin/partclone.extfs
shrinking /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/sbin/partclone.ntfsfixboot
shrinking /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/sbin/partclone.info
gzipping man pages under /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/sbin
patching script interpreter paths in /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11
checking for references to /build in /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11...
moving /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/sbin/* to /nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11/bin
/nix/store/n2y8zmnn72g4y702dddlacswxq97f54v-partclone-0.3.11

@Mic92 Mic92 merged commit 391b1ff into NixOS:master Apr 17, 2018
@emmanuelrosa emmanuelrosa deleted the partclone-all-fs branch April 17, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants