Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan-loader: fix broken symlink in output #39094

Merged
merged 1 commit into from May 2, 2018
Merged

vulkan-loader: fix broken symlink in output #39094

merged 1 commit into from May 2, 2018

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Apr 18, 2018

Motivation for this change

For some strange reason, non-critical parts of the build output of vulkan-loader are symlinks to the build directory, and this wasn't caught by any automated sanity checks. 1.0.61 (in 18.03) and later are confirmed affected, earlier not tested.

This fixes the install process to conservatively deref the invalid links.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@gebner gebner added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 18, 2018
@xeji
Copy link
Contributor

xeji commented May 2, 2018

@GrahamcOfBorg build vulkan-loader

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: vulkan-loader

Partial log (click to expand)

checking for references to /build in /nix/store/pwf2ahwa2h1j800zf417bdsaik4xgnlv-vulkan-loader-1.1.70.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos
shrinking /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos/bin/smoketest
shrinking /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos/bin/.cube-wrapped
shrinking /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos/bin/.cubepp-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos/bin
patching script interpreter paths in /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos
checking for references to /build in /nix/store/4lv7kcs6zpv0bpy3i63is38klmwbxy3x-vulkan-loader-1.1.70.0-demos...
/nix/store/pb02a21dvvpxhablbh668803180sns5c-vulkan-loader-1.1.70.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: vulkan-loader

Partial log (click to expand)

checking for references to /build in /nix/store/lkqvizvbp6ahxvd0mx9pcipz9lggxgfx-vulkan-loader-1.1.70.0-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos
shrinking /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos/bin/.cubepp-wrapped
shrinking /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos/bin/.cube-wrapped
shrinking /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos/bin/smoketest
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos/bin
patching script interpreter paths in /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos
checking for references to /build in /nix/store/mfmr4a9pjkyn20jzsrmhvs5wi9m7w5fp-vulkan-loader-1.1.70.0-demos...
/nix/store/4kc93445zvmjnl70f66gph9xp12mzp5q-vulkan-loader-1.1.70.0

@xeji xeji merged commit 599ecd5 into NixOS:master May 2, 2018
xeji pushed a commit that referenced this pull request May 2, 2018
@Ralith @xeji
vulkan-loader: fix broken symlink in output
7cbf6ca 
backport of #39094

(cherry picked from commit d1f7c51)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ralith @xeji @GrahamcOfBorg @samueldr @gebner