Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add a fromGit argument so it can be overridden #39093

Closed
wants to merge 3 commits into from

Conversation

catern
Copy link
Contributor

@catern catern commented Apr 18, 2018

There's no other way to override this attribute: override doesn't work
since it's not an argument of a callPackage call, and
overrideAttrs/overrideDerivation come in too late to change
things. Therefore, since nixUnstable is commented out, this change is
the only way to use fromGit and build from an unreleased git tag.

There's no other way to override this attribute: override doesn't work
since it's not an argument of a callPackage call, and
overrideAttrs/overrideDerivation come in too late to change
things. Therefore, since nixUnstable is commented out, this change is
the only way to use fromGit and build from an unreleased git tag.
@matthewbauer
Copy link
Member

Related: #37201

}:

let

sh = busybox-sandbox-shell;

common = { name, suffix ? "", src, fromGit ? false }: stdenv.mkDerivation rec {
common = { name, suffix ? "", src, fromGit ? fromGit }: stdenv.mkDerivation rec {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates an infinite recursion during eval. One of the two fromGit variables needs renaming.

@lukateras
Copy link
Member

Eval fixed (at least locally), that said nixUnstable is not commented out anymore, so this probably doesn't make much sense in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants