nix: add a fromGit argument so it can be overridden #39093
Closed
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no other way to override this attribute: override doesn't work since it's not an argument of a callPackage call, and overrideAttrs/overrideDerivation come in too late to change things. Therefore, since nixUnstable is commented out, this change is the only way to use fromGit and build from an unreleased git tag.
|
Related: #37201 |
xeji
reviewed
Apr 27, 2018
| }: | ||
|
|
||
| let | ||
|
|
||
| sh = busybox-sandbox-shell; | ||
|
|
||
| common = { name, suffix ? "", src, fromGit ? false }: stdenv.mkDerivation rec { | ||
| common = { name, suffix ? "", src, fromGit ? fromGit }: stdenv.mkDerivation rec { |
There was a problem hiding this comment.
This creates an infinite recursion during eval. One of the two fromGit variables needs renaming.
|
Eval fixed (at least locally), that said nixUnstable is not commented out anymore, so this probably doesn't make much sense in this case. |
GrahamcOfBorg
added
2.status: merge conflict
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no other way to override this attribute: override doesn't work
since it's not an argument of a callPackage call, and
overrideAttrs/overrideDerivation come in too late to change
things. Therefore, since nixUnstable is commented out, this change is
the only way to use fromGit and build from an unreleased git tag.