Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binutils: fix R_AARCH64_ABS32 on aarch64 #39082

Merged
merged 1 commit into from Apr 17, 2018
Merged

binutils: fix R_AARCH64_ABS32 on aarch64 #39082

merged 1 commit into from Apr 17, 2018

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

currently aarch64 builds of various packages (kernel, boot, qemu) fail on nixos-unstable-small due to https://sourceware.org/bugzilla/show_bug.cgi?id=22764

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Apr 17, 2018
View reviewed changes
pkgs/development/tools/misc/binutils/default.nix
# Version 2.30 introduced strict requirements on ELF relocations which cannot
# be satisfied on aarch64 platform. Add backported fix from bugzilla.
# https://sourceware.org/bugzilla/show_bug.cgi?id=22764
./relax-R_AARCH64_ABS32-R_AARCH64_ABS16-absolute.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using fetchpatch { url = "https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=patch;h=279b2f94168ee91e02ccd070d27c983fc001fe12;hp=f3b91ed8f96a4d41eef1c64a7e77c406ec763612"; sha256 = "..."}; was not possible here because the patch was adapted?

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build binutils

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: binutils

Partial log (click to expand)

/nix/store/yxy8f4a4abm0j5b88jwn7jnj0npd9f0w-binutils-wrapper-2.30

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: binutils

Partial log (click to expand)

these paths will be fetched (0.01 MiB download, 0.02 MiB unpacked):
  /nix/store/228wm9a5v5jb2p9vz9f11lg78vb7r9mi-binutils-wrapper-2.30
copying path '/nix/store/228wm9a5v5jb2p9vz9f11lg78vb7r9mi-binutils-wrapper-2.30' from 'https://cache.nixos.org'...
/nix/store/228wm9a5v5jb2p9vz9f11lg78vb7r9mi-binutils-wrapper-2.30

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: binutils

Partial log (click to expand)

these derivations will be built:
  /nix/store/v2i6aizkicl868xh8q1f516hr3xx0g2x-coreutils-8.29.drv
  /nix/store/h6qmk9z5yvackwrb1gdz745nhnp5kcfy-binutils-wrapper-2.30.drv
waiting for locks or build slots...
/nix/store/lgcjzvmpvcpgbmaq74dyj26icq0mhbzp-binutils-wrapper-2.30

@Mic92 Mic92 merged commit 229e629 into NixOS:staging Apr 17, 2018
@georgewhewell georgewhewell deleted the binutils-fix-aarch64-relocations branch April 17, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgewhewell @Mic92 @GrahamcOfBorg