Rename issue #3039 #3048
Merged
Rename issue #3039 #3048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rename DISABLE_INDEXES_PLUGIN_* settings #3039 |
felixfontein
requested changes
Apr 17, 2018
AUTHORS.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| * `Agustin Henze <https://github.com/agustinhenze>`_ | |||
| * `Agustin Henze <https://github.com/agustinhenze>`_ | |||
There was a problem hiding this comment.
You inserted a UTF-8 BOM here (a hexdump shows that the file now starts with ef bb bf).
There was a problem hiding this comment.
There was a problem hiding this comment.
I fixed this for now. In the future, please make sure your editor does not insert BOMs (never use notepad.exe to edit stuff like that)
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Kwpolska
requested changes
Apr 17, 2018
Kwpolska
reviewed
Apr 17, 2018
nikola/nikola.py
Outdated
| self.config['DISABLE_INDEXES'] = self.config['DISABLE_INDEXES_PLUGIN_INDEX_AND_ATOM_FEED'] | ||
|
|
||
| if 'DISABLE_INDEXES_PLUGIN_RSS_FEED' in self.config: | ||
| utils.LOGGER.warn('The DISABLE_INDEXES_PLUGIN_RSS_FEED setting was renamed DISABLE_MAIN_RSS_FEED') |
There was a problem hiding this comment.
You forgot one line here, but I’m going to add it myself.
Kwpolska
approved these changes
Apr 17, 2018
|
Thanks for contributing, @Knapstad! |
|
@Kwpolska thank you for letting me :) and thanks for your patiens, its my first contribution out side my own projects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description