visualvm: 1.3.9 -> 1.4 #39095

moaxcp · 2018-04-18T02:06:08Z

Motivation for this change

update version

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

joachifm · 2018-04-18T18:00:17Z

pkgs/development/tools/java/visualvm/default.nix


  src = fetchzip {
-    url = "https://github.com/visualvm/visualvm.src/releases/download/1.3.9/visualvm_139.zip";
-    sha256 = "1gkdkxssh51jczhgv680i42jjrlia1vbpcqhxvf45xcq9xj95bm5";
+    url = "https://github.com/visualvm/visualvm.src/releases/download/1.4/visualvm_14.zip";


Not a blocker but you could attempt to re-use the version attribute here to simplify bumps. It seems you could simply remove the dots in the version string for the archive basename.

Ok I will try it out.

You know I just realized that I am only changing the url. How do I remove the sources from the nix store to ensure the url actually works when I run nix-build?

The quick way is to just perturb the hash while you're trying things out ... or maybe use nix-prefetch-url -A ... which should ensure the fetcher actually runs. Anyway, this is not all that important, so I'd be happy to integrate this as-is,. the version string reuse can be iterated upon later.

joachifm · 2018-04-18T18:25:17Z

@GrahamcOfBorg build visualvm

GrahamcOfBorg · 2018-04-18T18:25:38Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: visualvm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-04-18T18:25:41Z

Success on x86_64-linux (full log)

Attempted: visualvm

Partial log (click to expand)

shrinking /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/profiler/lib/deployed/jdk16/solaris-sparc/libprofilerinterface.so
shrinking /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/platform/modules/lib/i386/linux/libjnidispatch-440.so
shrinking /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/platform/modules/lib/amd64/linux/libjnidispatch-440.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/bin
patching script interpreter paths in /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4
/nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/bin/.visualvm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4/platform/lib/nbexec: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4...
/nix/store/780wxr0dgn5s2rn2kqxsz1cvamzqaahx-visualvm-1.4

GrahamcOfBorg · 2018-04-18T18:26:58Z

Success on x86_64-darwin (full log)

Attempted: visualvm

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/rjimjb7crl0bvhja0b0yrk1mr2r6qm6f-visualvm-1.4/bin
patching script interpreter paths in /nix/store/rjimjb7crl0bvhja0b0yrk1mr2r6qm6f-visualvm-1.4
/nix/store/rjimjb7crl0bvhja0b0yrk1mr2r6qm6f-visualvm-1.4/bin/.visualvm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/rjimjb7crl0bvhja0b0yrk1mr2r6qm6f-visualvm-1.4/platform/lib/nbexec: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/rjimjb7crl0bvhja0b0yrk1mr2r6qm6f-visualvm-1.4

moaxcp · 2018-04-19T01:32:05Z

pkgs/development/tools/java/visualvm/default.nix

+  };
+
+  desktopItem = makeDesktopItem {
+      name = "visualvm";


Any ideas on how to add the icon? There is an icon located at etc/visualvm.icns. Is it ok to just set icon to that location?

I'm just wondering if an icns file is ok or does it need to be a png?

Per https://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html the supported formats are png, xpm, and svg.

I can't find a png file in the source. Would it be bad to convert the image to png using image magick?

No idea, sorry

joachifm · 2018-04-21T19:40:24Z

@GrahamcOfBorg build visualvm

GrahamcOfBorg · 2018-04-21T19:40:42Z

Success on x86_64-darwin (full log)

Attempted: visualvm

Partial log (click to expand)

building
no Makefile, doing nothing
installing
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/c1jvf8kvv725hc2837h5zx6hiar86ppq-visualvm-1.4/bin
patching script interpreter paths in /nix/store/c1jvf8kvv725hc2837h5zx6hiar86ppq-visualvm-1.4
/nix/store/c1jvf8kvv725hc2837h5zx6hiar86ppq-visualvm-1.4/bin/.visualvm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/c1jvf8kvv725hc2837h5zx6hiar86ppq-visualvm-1.4/platform/lib/nbexec: interpreter directive changed from "/bin/sh" to "/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/sh"
/nix/store/c1jvf8kvv725hc2837h5zx6hiar86ppq-visualvm-1.4

GrahamcOfBorg · 2018-04-21T19:41:06Z

Success on x86_64-linux (full log)

Attempted: visualvm

Partial log (click to expand)

shrinking /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/profiler/lib/deployed/jdk16/solaris-i386/libprofilerinterface.so
shrinking /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/profiler/lib/deployed/jdk16/solaris-sparc/libprofilerinterface.so
shrinking /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/profiler/lib/deployed/jdk16/solaris-sparcv9/libprofilerinterface.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/bin
patching script interpreter paths in /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4
/nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/bin/.visualvm-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4/platform/lib/nbexec: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4...
/nix/store/6pglmdcv08f0ns0c8y8zdpnsl3r2av5s-visualvm-1.4

GrahamcOfBorg · 2018-04-21T19:41:22Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: visualvm

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

joachifm · 2018-04-21T19:43:29Z

Thank you

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 18, 2018

joachifm reviewed Apr 18, 2018

View reviewed changes

visualvm: 1.3.9 -> 1.4

a6ddd63

moaxcp force-pushed the master branch from 81f7fa8 to a6ddd63 Compare April 19, 2018 01:28

moaxcp commented Apr 19, 2018

View reviewed changes

joachifm merged commit dff29c6 into NixOS:master Apr 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

visualvm: 1.3.9 -> 1.4 #39095

visualvm: 1.3.9 -> 1.4 #39095

moaxcp commented Apr 18, 2018

joachifm Apr 18, 2018

moaxcp Apr 19, 2018

moaxcp Apr 19, 2018

joachifm Apr 19, 2018

joachifm commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

moaxcp Apr 19, 2018

moaxcp Apr 19, 2018

joachifm Apr 19, 2018

moaxcp Apr 20, 2018

joachifm Apr 21, 2018

joachifm commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

joachifm commented Apr 21, 2018

visualvm: 1.3.9 -> 1.4 #39095

visualvm: 1.3.9 -> 1.4 #39095

Conversation

moaxcp commented Apr 18, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joachifm commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

GrahamcOfBorg commented Apr 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joachifm commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

GrahamcOfBorg commented Apr 21, 2018

joachifm commented Apr 21, 2018