Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 3fd2b19d39a4
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 4dd40e05d381
Choose a head ref
  • 8 commits
  • 6 files changed
  • 4 contributors

Commits on Mar 30, 2018

  1. python3: 3.6.4 -> 3.6.5

    (cherry picked from commit 402a074)
    FRidh committed Mar 30, 2018
    Copy the full SHA
    786f498 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2018

  1. Increase max group name length to 32 characters

    With #36556, a check was introduced to make sure the user and group
    names do not exceed their respective maximum length. This is in part
    because systemd also enforces that length, but only at runtime.
    
    So in general it's a good idea to catch as much as we can during
    evaluation time, however the maximum length of the group name was set to
    16 characters according groupadd(8).
    
    The maximum length of the group names however is a compile-time option
    and even systemd allows more than 16 characters. In the mentioned pull
    request (#36556) there was already a report that this has broken
    evaluation for people out there.
    
    I have also checked what other distributions are doing and they set the
    length to either 31 characters or 32 characters, the latter being more
    common.
    
    Unfortunately there is a difference between the maximum length enforced
    by the shadow package and systemd, both for user name lengths and group
    name lengths. However, systemd enforces both length to have a maximum of
    31 characters and I'm not sure if this is intended or just a off-by-one
    error in systemd.
    
    Nevertheless, I choose 32 characters simply to bring it in par with the
    maximum user name length.
    
    For the NixOS assertion however, I use a maximum length of 31 to make
    sure that nobody accidentally creates services that contain group names
    that systemd considers invalid because of a length of 32 characters.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    Closes: #38548
    Cc: @vcunat, @fpletz, @qknight
    (cherry picked from commit 99ba1cb)
    aszlig committed Apr 8, 2018
    Copy the full SHA
    7361cad View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    504f962 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    39809e3 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2018

  1. Copy the full SHA
    563ee7f View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2018

  1. Merge #39000: rustc: disable tests for aarch64

    (cherry picked from commit 74ed06e)
    Mic92 authored and vcunat committed Apr 17, 2018
    Copy the full SHA
    b694e7b View commit details
    Browse the repository at this point in the history
  2. Merge branch 'release-18.03' into staging-18.03

    Not many rebuilds, but let's sync anyway.
    vcunat committed Apr 17, 2018
    Copy the full SHA
    8102a41 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4dd40e0 View commit details
    Browse the repository at this point in the history