-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Dir.mkdir_p to FileUtils.mkdir_p #6092
Conversation
7dc3f24
to
4bd2ea9
Compare
What about # Removes the directory at the given path. or it "tests delete with a path that cannot be removed" do there "Removes" should be better "Deletes" and "removed" should be "deleted" I think. Or just change |
I will change everything to |
We should be moving everything to |
Adding |
For me |
I agree with you, and I actually like this change. What i'm suggesting is to break everyone's path handing at once in one release not break it a little bit few releases in a row. If we're going to make a massive breaking change on the horizon anyway we might as well bundle this up with that. Now just make sure we don't forget this when the time comes :) |
Finally I quite agree with you. Ok to keep |
8f75d0a
to
5f76eb3
Compare
@RX14 Are you OK with this change - WDYT? |
It doesn't make any sense to separate Subsequently, I'd leave |
Agree @straight-shoota , it would be even greater to have a recursive argument (or something else) in common for commands like |
Dir.mkdir_p is also moved to FileUtils.mkdir_p