Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnunet-svn: mark as broken #40401

Merged
merged 1 commit into from May 12, 2018
Merged

gnunet-svn: mark as broken #40401

merged 1 commit into from May 12, 2018

Conversation

pstn
Copy link
Contributor

@pstn pstn commented May 12, 2018 •
edited

Motivation for this change

Gnunet switched develpoment from svn to git and removed the svn repositories. A replacement -svn package has already been added.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 12, 2018

Gnunet switched develpoment from svn to git and removed the svn repositories.

Then there's no point in marking gnunet-svn as broken on master, let's remove it right away.

@pstn
Copy link
Contributor Author

pstn commented May 12, 2018

@xeji If you say so. Removed it.

@xeji
Copy link
Contributor

xeji commented May 12, 2018

Thanks. Our svn revision was from 2013 anyway 😄

@xeji xeji merged commit 22cd5eb into NixOS:master May 12, 2018
@pstn
Copy link
Contributor Author

pstn commented May 12, 2018

Yeah, I'll bump the git version a little bit more often. Maybe next year? ^_~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pstn @xeji @GrahamcOfBorg