nixos/tests: add jbake #40421
Merged
nixos/tests: add jbake #40421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
May 13, 2018
nixos/tests/jbake.nix
Outdated
| $machine->waitForUnit("default.target"); | ||
|
|
||
| my $expected = "JBake v${pkgs.jbake.version}"; | ||
| my $result = $machine->succeed("jbake"); |
There was a problem hiding this comment.
This is not testing a service. We do not have yet the test derivations as proposed by @Profpatsch.
However what you could add to development/tools/jbake/default.nix is:
{ # ...
checkPhase = ''
jbake | grep -q "${version}" || (echo "jbake did not return correct version"; exit 1)
'';
doCheck = true;
}There was a problem hiding this comment.
This will be also seen during build time, while for the test we have to remember that it exists.
There was a problem hiding this comment.
Thanks! This would probably have been easier. When do nixos/tests get run?
There was a problem hiding this comment.
When nixos/release.nix is build on hydra as part of the nixos jobset.
GrahamcOfBorg
added
10.rebuild-linux: 1-10
and removed
6.topic: nixos
10.rebuild-linux: 0
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding test to prevent bot upgrades from causing issues.
Things done
tested with
nix-build nixos/tests/jbake.nixbuild-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)