Ghcjs 8.2 & 8.4 #40392
Ghcjs 8.2 & 8.4 #40392
Conversation
|
Seems rebasing caused the build to fail. |
|
|
|
Adding GHCJS 8.4 as well, since they're closely related and both have build failures |
|
Ok we have what seems to be a working workaround for the panic. So I think this is good to merge. @peti what do you think? |
| buildInputs = [cabal2nix yq]; | ||
| } '' | ||
| ( | ||
| printf '{ callPackage, configuredSrc }:\n\n{\n\n' |
There was a problem hiding this comment.
Might be worth a comment explaining what this is doing O_O
|
@peti Is there any change necessary to have these built by hydra and cached? Or will it do the compilers automatically? |
|
Yes, hydra.nixos.org will compile them; no further changes necessary. |
|
@peti are you sure? The expressions are on the nixos-unstable channel but they are not cached. |
|
They haven't compiled on Hydra successfully yet: https://hydra.nixos.org/eval/1458249?filter=ghcjs&compare=1457965 |
|
@ElvishJerricco, neither of these builds has ever succeeded on Hydra:
Can you please take a look at these issues? If the package does not build, then we should have this code in Nixpkgs and I'm inclined to revert these changes if that state does not change. |
|
Right, sorry. Had to wait on the GHC 8.0 fix. Though that build error is super obscure. |
|
This is now in nixpkgs-unstable. |
Motivation for this change
Adds GHCJS 8.2 and GHCJS 8.4.
These builds are currently blocked on ghcjs/ghcjs#654. It's important that these builds be checked more than once until that bug is fixed, as it is an intermittent failure.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)